-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report known mysql database configuration errors as warnings #11221
Merged
alexandre-normand
merged 8 commits into
master
from
alex.normand/mysql-send-db-config-errors-as-warnings
Jan 29, 2022
Merged
Report known mysql database configuration errors as warnings #11221
alexandre-normand
merged 8 commits into
master
from
alex.normand/mysql-send-db-config-errors-as-warnings
Jan 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-normand
force-pushed
the
alex.normand/mysql-send-db-config-errors-as-warnings
branch
from
January 27, 2022 01:55
a4dca0a
to
15d2afa
Compare
alexandre-normand
changed the title
Add warning reporting on mysql database configuration errors
Report known mysql database configuration errors as warnings
Jan 27, 2022
djova
requested changes
Jan 28, 2022
alexandre-normand
force-pushed
the
alex.normand/mysql-send-db-config-errors-as-warnings
branch
from
January 28, 2022 21:21
aa70dad
to
554847d
Compare
alexandre-normand
force-pushed
the
alex.normand/mysql-send-db-config-errors-as-warnings
branch
from
January 28, 2022 21:45
c3dd89b
to
7406698
Compare
djova
previously approved these changes
Jan 28, 2022
djova
approved these changes
Jan 28, 2022
alexandre-normand
deleted the
alex.normand/mysql-send-db-config-errors-as-warnings
branch
January 29, 2022 00:15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This sends warnings in well-known database configuration errors to improve customers' visibility into issues due to missing or wrong database configuration required by the integration to work properly. Those warnings will appear in the agent status like this:
As well as show up in the infrastructure views.
The database configuration errors covered here are:
datadog.explain_statement
procedure or missing grant to run itexplain_statement
or missing grant to run itMotivation
Provide better ways for customers to identify database configuration errors and resolve them.
Additional Notes
The links included in the warnings don't currently exist but will be created as part of work planned ahead of the 7.35.0 release. We should make sure here that the links do make sense here even if the content doesn't already exist as we're aiming for stable permanent links.
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached