Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mysql_version and mysql_flavor to dbm query metrics payloads #10915

Merged

Conversation

alexandre-normand
Copy link
Contributor

What does this PR do?

This adds mysql_version to the query metrics payloads.

Motivation

Having the mysql version with query metrics is useful and it's more consistent with how we also have it for sqlserver and postgres.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #10915 (85cbf2b) into master (4b152c2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Flag Coverage Δ
mysql 87.11% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@alexandre-normand alexandre-normand merged commit be5441a into master Dec 21, 2021
@alexandre-normand alexandre-normand deleted the alex.normand/add=mysql-version-to-dbm-metrics branch December 21, 2021 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants