Fix mysql query metric collection not recovering after database restarts #10811
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes an issue where the query metrics collection would never recover when a monitored mysql instance would be restarted. This would manifest itself by repeated logging of
With customers having to restart the agent in order for query metric collection to resume.
This addresses that failure by catching the InterfaceError and closing the query metric's job connection so that the next run gets a new connection.
Motivation
Improve resiliency of the integration.
Additional Notes
This is a tricky one to unit so, to validate that this works, I first reproduced the error by restarting my test RDS mysql instance. I then ran with the changes that you see in this PR and confirmed that the statement metrics collection job was getting shut down and restarted on a lost connection during a database reboot:
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached