Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mysql additional vars #10573

Merged
merged 10 commits into from
Nov 11, 2021
Merged

Mysql additional vars #10573

merged 10 commits into from
Nov 11, 2021

Conversation

notemusic110
Copy link
Contributor

What does this PR do?

Sometimes the result of "SHOW VARIABLE" or "SHOW STATUS" is not in const.
Since using a custom query is considered an unnecessary process, we are going to send the result value using yaml as needed.

Motivation

As i am monitoring, i need to collect more parameters.

Review checklist (to be filled by reviewers)

  • [v] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • [v] PR title must be written as a CHANGELOG entry (see why)
  • [v] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • [v] PR must have changelog/ and integration/ labels attached

@notemusic110 notemusic110 requested review from a team as code owners November 8, 2021 09:29
@notemusic110
Copy link
Contributor Author

could i change the label? i can't modify the label section

hithwen
hithwen reviewed Nov 8, 2021
View reviewed changes
mysql/datadog_checks/mysql/data/conf.yaml.example Outdated
@@ -83,6 +83,30 @@ instances:
# cert: <CERT_FILE_PATH>
# ca: <CA_PATH_FILE>

## @param additional_status - list of mappings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is autogenerated. Changes here need to come from the spec file and then synced with ddev validate config -s

hithwen
hithwen reviewed Nov 8, 2021
View reviewed changes
mysql/datadog_checks/mysql/config_models/instance.py Outdated
@@ -81,6 +81,24 @@ class Config:
key: Optional[str]


class AdditionalStatus(BaseModel):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is autogenerated. Changes here need to come from the spec file and then synced with ddev validate models -s

hithwen
hithwen reviewed Nov 8, 2021
View reviewed changes
mysql/datadog_checks/mysql/config_models/defaults.py Outdated
@@ -96,6 +96,14 @@ def instance_ssl(field, value):
return get_default_field_value(field, value)


def instance_additional_status(field, value):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is autogenerated. Changes here need to come from the spec file and then synced with ddev validate models -s

apigirl
apigirl previously approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@apigirl apigirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for docs

@notemusic110
Copy link
Contributor Author

notemusic110 commented Nov 9, 2021 •
edited
Loading

@hithwen , Thank you for answer. Fixed the related code.
I've only modified the spec, but sync related errors are still occurring. There is no sync related command in the pipeline, can you please tell me how to do it?

i was check ddev sync about model and config through code push.

@codecov
Copy link

codecov bot commented Nov 9, 2021 •
edited
Loading

Codecov Report

Merging #10573 (0d5b1c6) into master (763da12) will increase coverage by 0.00%.
The diff coverage is 84.37%.

Flag Coverage Δ
mysql 86.37% <84.37%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@notemusic110
Copy link
Contributor Author

@apigirl , please check again this PR :)

@fanny-jiang fanny-jiang merged commit 0186dbd into DataDog:master Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hithwen hithwen hithwen left review comments

@fanny-jiang fanny-jiang fanny-jiang approved these changes

@apigirl apigirl apigirl left review comments

Assignees
No one assigned
Labels
integration/mysql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@notemusic110 @hithwen @fanny-jiang @apigirl