Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable extra_status_metrics and replication metrics by default when DBM is enabled #10541

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Enable extra_status_metrics and replication metrics by default when DBM is enabled #10541

merged 1 commit into from
Nov 10, 2021

Conversation

justiniso
Copy link
Contributor

What does this PR do?

Changes the default behavior when DBM is enabled so that the innodb status metrics and replication metrics are automatically collected.

Motivation

These extra settings provide richer data so we should be sure to collect them for DBM insights.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ghost ghost added the integration/mysql label Nov 2, 2021
@codecov
Copy link

codecov bot commented Nov 2, 2021 •
edited
Loading

Codecov Report

Merging #10541 (187313f) into master (7619c36) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Flag Coverage Δ
mysql 86.40% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@justiniso justiniso marked this pull request as ready for review November 4, 2021 17:37
@justiniso justiniso requested a review from a team as a code owner November 4, 2021 17:37
@justiniso justiniso merged commit f81e4d1 into master Nov 10, 2021
@justiniso justiniso deleted the justindd/enable-default-metrics-for-dbm branch November 10, 2021 16:16
@ian28223 ian28223 mentioned this pull request Aug 28, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristineTChen ChristineTChen ChristineTChen approved these changes

Assignees
No one assigned
Labels
integration/mysql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justiniso @ChristineTChen