Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proxy support in client initialization #10188

Merged
merged 18 commits into from
Sep 28, 2021
Merged

Add proxy support in client initialization #10188

merged 18 commits into from
Sep 28, 2021

Conversation

ChristineTChen
Copy link
Contributor

@ChristineTChen ChristineTChen commented Sep 22, 2021 •
edited
Loading

What does this PR do?

This PR adds proxy support.

Currently, users can only configure proxy settings by using environment variables.

The source states that proxy support via configuration files is not yet available
https://github.com/boto/botocore/blob/6a0f13261b3ecaf4e2cebbf134c3b3c7005a3c78/botocore/endpoint.py#L311-L314

Motivation

Support case

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ChristineTChen ChristineTChen requested a review from a team as a code owner September 22, 2021 00:09
@ChristineTChen ChristineTChen requested a review from a team as a code owner September 22, 2021 01:55
@ghost ghost added the documentation label Sep 22, 2021
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

2 similar comments
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@codecov
Copy link

codecov bot commented Sep 22, 2021 •
edited
Loading

Codecov Report

Merging #10188 (82e7fcf) into master (d3823ac) will decrease coverage by 0.00%.
The diff coverage is 77.77%.

Flag Coverage Δ
amazon_msk 86.63% <77.77%> (-1.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

sarina-dd
sarina-dd previously approved these changes Sep 24, 2021
View reviewed changes
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

1 similar comment
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@ChristineTChen
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

sarah-witt
sarah-witt reviewed Sep 28, 2021
View reviewed changes
Copy link
Contributor

@sarah-witt sarah-witt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I left a few comments

amazon_msk/datadog_checks/amazon_msk/amazon_msk.py Show resolved Hide resolved
amazon_msk/datadog_checks/amazon_msk/check.py Show resolved Hide resolved
amazon_msk/datadog_checks/amazon_msk/utils.py Show resolved Hide resolved
amazon_msk/tests/test_unit.py Show resolved Hide resolved
@ChristineTChen ChristineTChen merged commit ec05071 into master Sep 28, 2021
@ChristineTChen ChristineTChen deleted the cc/msk-proxy branch September 28, 2021 18:54
@sarah-witt sarah-witt mentioned this pull request Oct 8, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah-witt sarah-witt sarah-witt left review comments

@fanny-jiang fanny-jiang fanny-jiang approved these changes

@sarina-dd sarina-dd sarina-dd left review comments

Assignees
No one assigned
Labels
documentation integration/amazon_msk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChristineTChen @fanny-jiang @sarah-witt @sarina-dd