Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support v2 system volumes api #10133

Merged
merged 3 commits into from
Sep 15, 2021
Merged

Support v2 system volumes api #10133

merged 3 commits into from
Sep 15, 2021

Conversation

coignetp
Copy link
Contributor

@coignetp coignetp commented Sep 15, 2021 •
edited
Loading

What does this PR do?

Support /systeminfo/volumes new format

Motivation

Support case

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ghost ghost added the integration/harbor label Sep 15, 2021
@coignetp coignetp changed the title Paul/harbor v2 Support v2 system volumes api Sep 15, 2021
@codecov
Copy link

codecov bot commented Sep 15, 2021 •
edited
Loading

Codecov Report

Merging #10133 (e342f83) into master (0b6de8a) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Flag Coverage Δ
harbor 83.29% <100.00%> (-8.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@coignetp coignetp marked this pull request as ready for review September 15, 2021 11:47
@coignetp coignetp requested a review from a team as a code owner September 15, 2021 11:47
@coignetp coignetp merged commit e28eb39 into master Sep 15, 2021
@coignetp coignetp deleted the paul/harbor-v2 branch September 15, 2021 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianVeaux FlorianVeaux FlorianVeaux approved these changes

Assignees
No one assigned
Labels
integration/harbor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coignetp @FlorianVeaux