Writer: Fix bug in last commit; fix old streaming bug on Mac OS X #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 7f71d02 fixed unsafe slice warnings, but incorrectly removed a line of code from Writer.nextInputBuffer. This causes the writer to produce incorrect results. Add a test that reproduces this bug. On Mac OS X, this test also often fails even with this bug fix, or with the version before the bug. It turns out that LZ4_compress_fast_continue will combine contiguous buffers for small writes, in an attempt to improve compression. To disable this, we must separate the buffers. See: lz4/lz4#473 (comment)
evanj
force-pushed
the
evan.jones/fix-streaming-bug
branch
from
ab5185b to
05319fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 7f71d02 fixed unsafe slice warnings, but incorrectly
removed a line of code from Writer.nextInputBuffer. This causes the
writer to produce incorrect results. Add a test that reproduces this
bug.
On Mac OS X, this test also often fails even with this bug fix, or
with the version before the bug. It turns out that
LZ4_compress_fast_continue will combine contiguous buffers for small
writes, in an attempt to improve compression. To disable this, we
must separate the buffers. See:
lz4/lz4#473 (comment)