Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(handle): call to ddwaf_init is missing a call to unsafe.KeepAlive #112

Merged
merged 1 commit into from
Oct 18, 2024
Merged

fix(handle): call to ddwaf_init is missing a call to unsafe.KeepAlive #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions handle.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,10 @@ func NewHandle(rules any, keyObfuscatorRegex string, valueObfuscatorRegex string
diagnosticsWafObj := new(bindings.WafObject)
defer wafLib.WafObjectFree(diagnosticsWafObj)

unsafe.KeepAlive(encoder.cgoRefs)
cHandle := wafLib.WafInit(obj, config, diagnosticsWafObj)
unsafe.KeepAlive(encoder.cgoRefs) // Keep this AFTER the call to wafLib.WafInit

return newHandle(wafLib.WafInit(obj, config, diagnosticsWafObj), diagnosticsWafObj)
return newHandle(cHandle, diagnosticsWafObj)
}

// newHandle creates a new Handle from a C handle (nullable) and a diagnostics object.
Expand Down
Loading