[Linear] Ensure a resource is only serialized/hashed at most once in linear cache #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valerian-roche
force-pushed
the
vr/serialize-once
branch
from
cca7965 to
4100f52
Compare
atollena
approved these changes
Dec 17, 2024
| @@ -179,13 +177,13 @@ type RawResponse struct { | |||
| Version string | |||
|
|
|||
| // Resources to be included in the response. | |||
| Resources []types.ResourceWithTTL | |||
| resources []cachedResource | |||
There was a problem hiding this comment.
Don't forget to fix the godoc comments (here and everywhere).
pkg/cache/v3/linear.go
Outdated
| cacheVersion: cacheVersion, | ||
| } | ||
| } | ||
|
|
||
| // getMarshaledResource lazily marshals the resource and return the bytes. |
There was a problem hiding this comment.
Suggested change
| // getMarshaledResource lazily marshals the resource and return the bytes. | |
| // getMarshaledResource lazily marshals the resource and returns the bytes. |
pkg/cache/v3/linear.go
Outdated
| return c.marshaledResource, nil | ||
| } | ||
|
|
||
| // getStableVersion lazily hashes the resource and return the stable hash used to track version changes. |
There was a problem hiding this comment.
Suggested change
| // getStableVersion lazily hashes the resource and return the stable hash used to track version changes. | |
| // getStableVersion lazily hashes the resource and returns the stable hash used to track version changes. |
zhiyanfoo
approved these changes
Dec 17, 2024
| Name: GetResourceName(resource.Resource), | ||
| Ttl: durationpb.New(*resource.TTL), | ||
| func (r *RawResponse) marshalTTLResource(resource cachedResource) (*anypb.Any, error) { | ||
| if resource.ttl == nil { |
There was a problem hiding this comment.
How are TTLs for resources decided out of curiosity?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the go-control-plane caches (both linear and snapshots) will serialize the resource as many time as there are clients receiving it.
This is an issue with control-planes watched by a lot of clients, especially with large resources (e.g. endpoints)
This PR ensures that the serialization occurs at most once per resource:
WithSotwStableVersionsis set