You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifies the (*Manager) Close() method to close the probes concurrently.
Motivation
The Networks team has dozens of kprobes and each one takes 30-50ms to call the close() syscall on the perf_kprobe PMU, which adds up to an extra second of time on each test. We set up and tear down the tracer entirely for each test, which across all our tests, adds up to minutes of test time.
2025-01-17 18:25:00 UTC ℹ️ MergeQueue: waiting for PR to be ready
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.
2025-01-17 22:25:09 UTC⚠️MergeQueue: This merge request was unqueued
devflow unqueued this merge request: It did not become mergeable within the expected time
2025-01-21 22:42:23 UTC ℹ️ MergeQueue: waiting for PR to be ready
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.
2025-01-21 23:00:35 UTC⚠️MergeQueue: This merge request was unqueued
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dd-devflow
bot
added
mergequeue-status: waiting
and removed
mergequeue-status: waiting
labels
pimlu
force-pushed
the
stuart.geipel/close-probes-concurrently
branch
from
What does this PR do?
Modifies the
(*Manager) Close()method to close the probes concurrently.Motivation
The Networks team has dozens of kprobes and each one takes 30-50ms to call the close() syscall on the perf_kprobe PMU, which adds up to an extra second of time on each test. We set up and tear down the tracer entirely for each test, which across all our tests, adds up to minutes of test time.
Additional Notes
Describe how to test your changes
CI passes here showing KMT was all green: DataDog/datadog-agent#33054