-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unix socket support #61
Conversation
Since our new dogstasd server is able to listen to a UNIX socket.
As otherwise the call is blocking
Ruby 1.9 seems to fail because of this error. |
hi @sullerandras , thanks a lot for your contribution! I'm tagging the library maintainers to help figure out how to fix the tests. |
hi @sullerandras, Could you please rebase on master, as tests are fixed now? Regards |
@sullerandras tried to make tests on 2.1.10 pass with no success, do you have any idea what that could be? I think we can drop tests on jruby1.9 but 2.1 seems to work despite the tests :( |
This should solve the issue with Ruby 2.1 which comes with Minitest 4.7.5 default gem but we want to use Minitest 5.
This reverts commit ea41510.
@masci It seems like MRI Ruby 2.1 comes with an embedded minitest 4.7.5 and |
so rake does not add /Users/andras/.rvm/rubies/ruby-2.1.10/lib/ruby/2.1.0 to the beginning of $LOAD_PATH which forces to use Minitest 4.7.5. This should solve the problem with running the specs on Ruby 2.1
@masci Changed to |
@sullerandras awesome, thanks! I think this is a good tradeoff for keeping 2.1 tests around. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
dogstatsd-ruby has supported Unix domain socket. cf. DataDog/dogstatsd-ruby#61
dogstatsd-ruby has supported Unix domain socket. cf. DataDog/dogstatsd-ruby#61
dogstatsd-ruby has supported Unix domain socket. cf. DataDog/dogstatsd-ruby#61
dogstatsd-ruby has supported Unix domain socket. cf. DataDog/dogstatsd-ruby#61
Continuation of #55
To test it locally i installed the new datadog agent to my Mac following the instructions here then used a simple ruby script like this:
I tried all scenarios listed in the testing guide and it worked.