Add support to query time series points via dog.get_points(from, to, query) #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # | ||
| def get_points(from, to, query) | ||
| @metric_svc.get(from, to, query) | ||
| end |
There was a problem hiding this comment.
Can we change the method signature to be consistent with graph_snapshot, i.e.
def get_points(query, start, end)
[...]
end
|
Looks great, thanks for bringing the feature @blakehilscher ! I just added a small nitpick. Other than that, it looks ready to be merged. |
|
Ohh, i just noticed Travis is reporting a few tailor style check violations: https://travis-ci.org/DataDog/dogapi-rb/jobs/119659050. Would you mind taking a pass on it too please ? |
|
I rebased your work on top of the current state of the Thanks again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get points from a Datadog metric.