Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add service level objectives support #224

Merged
merged 3 commits into from
Feb 11, 2020
Merged

Conversation

phillip-dd
Copy link
Contributor

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue, or add one feature, at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

Description of the Change

  • This PR addresses the 1.9 compatibility issues.
  • Adds a "poor man's hash without indifferent access" to keep the method APIs manageable while also not forcing library users to remember to use string or symbol keys

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@phillip-dd phillip-dd requested a review from a team as a code owner February 10, 2020 03:33
@phillip-dd phillip-dd force-pushed the revert-revert-slos branch 2 times, most recently from ef3b2a2 to 219e2e3 Compare February 10, 2020 03:44
# my_hash = { 'foo' => 1 }
# Dogapi.symbolized_access(my_hash)
# my_hash[:foo] # => 1
def Dogapi.symbolized_access(hash)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reasoning behind this one ?
We already have a few endpoints that use a hash for options, but aren't using this symbolized access.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking across the other usages, all of the other options are merged into the body without modification. In a few cases here we construct a deeper object in the body based on the flat options passed in.

@zippolyte zippolyte added the changelog/Added Added features results into a minor version bump label Feb 11, 2020
@phillip-dd phillip-dd merged commit 8be8d0f into master Feb 11, 2020
@phillip-dd phillip-dd deleted the revert-revert-slos branch February 11, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/Added Added features results into a minor version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants