Revert "add service level objectives support (#188)" #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cd70fef.
dcoleman17
approved these changes
Nov 4, 2019
phillip-dd
added a commit
that referenced
this pull request
Feb 10, 2020
6 tasks
phillip-dd
added a commit
that referenced
this pull request
Feb 10, 2020
phillip-dd
added a commit
that referenced
this pull request
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit cd70fef.
The SLO functions have some new syntax (using keyword arguments) that doesn't work for Ruby versions < 2.0. Due to this, the client can't be initialized for users using Ruby < 2.0
I'm also seeing an traceback on Ruby 2.4 when attempting to
editan SLO. Lets revert this and fix it and release it in a future client release.