-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add opentelemetry env specific setup #9529
Merged
kayayarai
merged 17 commits into
DataDog:master
from
ericmustin:add_otel_collector_config
Feb 3, 2021
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
1d5287c
add opentelemtry env specific setup
ericmustin 7f4f811
update env var for hostname config
ericmustin 8f223d5
update otel docs with feedback
ericmustin 025780a
add grpc protocol to otel config example
ericmustin 8b9d7da
Update content/en/tracing/setup_overview/open_standards/_index.md
ericmustin eb00903
add feedback round 2
ericmustin 73be4c0
Merge branch 'add_otel_collector_config' of github.com:ericmustin/doc…
ericmustin 561818b
add opentelemtry env specific setup
ericmustin 8bd6e09
update env var for hostname config
ericmustin 8010ade
update otel docs with feedback
ericmustin 10e5daa
add grpc protocol to otel config example
ericmustin 048e8cd
Merge branch 'ericmustin/add_otel_collector_config' of github.com:Dat…
ericmustin 173f651
Apply suggestions from code review
kayayarai 6343a84
Merge branch 'add_otel_collector_config' into ericmustin/add_otel_col…
ericmustin 5eb8705
[otel docs] moar indentation
ericmustin 43eac63
fix indent
kayayarai 3d1d5d4
fix indent
kayayarai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we can mostly get rid of this section and just link here instead: https://opentelemetry.io/docs/collector/getting-started/#docker, making clear that we are present in the contrib flavor.
I don't think we should explain how to use Docker or how to use the OpenTelemetry Collector in general in Datadog docs, we should keep this for Datadog exporter specific configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These sections are quite misleading (note the
kill $pid1; docker stop otelcol
at the end of the docker command, for example) and have the user cloning the repo locally. i think it's better to have working examples in our docs and then contrib upstream to improve the upstream docs, and when those are improved we can point to them directly.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, let's keep it then. Can you open an issue for this on the https://github.com/open-telemetry/opentelemetry.io repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added open-telemetry/opentelemetry.io#370
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also added for rbac: open-telemetry/opentelemetry-collector-contrib#2274