Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MA-554] Document the new Monitor.can_delete endpoint. #5856

Merged
merged 3 commits into from
Dec 13, 2019
Merged

[MA-554] Document the new Monitor.can_delete endpoint. #5856

merged 3 commits into from
Dec 13, 2019

Conversation

armcburney
Copy link
Member

What does this PR do?

Adds documentation and code examples for the new Monitor.can_delete endpoint.

Motivation

The documentation does not exist.

Preview link

https://docs-staging.datadoghq.com/armcburney/can_delete_endpoint/api/?lang=bash#check-if-a-monitor-can-be-deleted

Additional Notes

@armcburney armcburney requested a review from a team as a code owner November 6, 2019 17:01
@armcburney armcburney requested a review from a team November 6, 2019 17:06
apigirl
apigirl approved these changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@apigirl apigirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from the documentation side! let us know in #documentation on slack when you have the other reviews you're looking for and are ready to merge in

@apigirl apigirl added API Do Not Merge Just do not merge this PR :) labels Nov 8, 2019
@l0k0ms l0k0ms mentioned this pull request Nov 12, 2019
Merged
@l0k0ms
Copy link
Contributor

l0k0ms commented Dec 13, 2019

Lib are now released:
https://github.com/DataDog/dogapi-rb/releases/tag/1.38.0
https://github.com/DataDog/datadogpy/releases/tag/v0.33.0

@l0k0ms l0k0ms merged commit 52e61b2 into master Dec 13, 2019
@l0k0ms l0k0ms deleted the armcburney/can_delete_endpoint branch December 13, 2019 16:58
sarina-dd pushed a commit that referenced this pull request Dec 13, 2019
Merge pull request #5856 from DataDog/armcburney/can_delete_endpoint
f45b2c0 
[MA-554] Document the new `Monitor.can_delete` endpoint.
@l0k0ms l0k0ms mentioned this pull request Dec 23, 2019
Merged
@apigirl apigirl restored the armcburney/can_delete_endpoint branch March 25, 2020 21:15
@apigirl apigirl deleted the armcburney/can_delete_endpoint branch March 25, 2020 21:40
@apigirl apigirl restored the armcburney/can_delete_endpoint branch March 27, 2020 18:31
@l0k0ms l0k0ms deleted the armcburney/can_delete_endpoint branch March 30, 2020 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@platinummonkey platinummonkey platinummonkey approved these changes

@apigirl apigirl apigirl approved these changes

Assignees
No one assigned
Labels
Do Not Merge Just do not merge this PR :)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@armcburney @l0k0ms @platinummonkey @apigirl