Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-TICKET] Add Ruby GVL profiling to documentation #26616

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

ivoanjo
Copy link
Member

@ivoanjo ivoanjo commented Dec 5, 2024

What does this PR do? What is the motivation?

This PR adds the Ruby GVL profiling feature to the documentation. This feature was introduced in DataDog/dd-trace-rb#3929 and mentioned in the 2.4.0 release notes https://github.com/DataDog/dd-trace-rb/releases/tag/v2.4.0 but we had not yet updated the docs to mention it.

Merge instructions

Merge readiness:

  • Ready for merge

Additional notes

N/A

This PR adds the Ruby GVL profiling feature to the documentation. This
feature was introduced in
DataDog/dd-trace-rb#3929 and mentioned
in the 2.4.0 release notes
https://github.com/DataDog/dd-trace-rb/releases/tag/v2.4.0 but we had
not yet updated the docs to mention it.
@ivoanjo ivoanjo requested a review from a team as a code owner December 5, 2024 09:02
content/en/profiler/enabling/ruby.md Outdated Show resolved Hide resolved
content/en/profiler/enabling/ruby.md Outdated Show resolved Hide resolved
@ivoanjo ivoanjo requested a review from neko-dd December 8, 2024 03:13
@ivoanjo
Copy link
Member Author

ivoanjo commented Dec 9, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 9, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-09 08:42:39 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-12-09 12:42:43 UTC ⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

@neko-dd
Copy link
Contributor

neko-dd commented Dec 9, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 9, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-09 17:45:12 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 6m.

@dd-mergequeue dd-mergequeue bot merged commit c15ed7d into master Dec 9, 2024
25 of 29 checks passed
@dd-mergequeue dd-mergequeue bot deleted the ivoanjo/ruby-gvl-profiling branch December 9, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants