Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RUM-1016] Browser RUM: add view.name as updatable property #19632

Merged
merged 1 commit into from
Sep 13, 2023
Merged

[RUM-1016] Browser RUM: add view.name as updatable property #19632

merged 1 commit into from
Sep 13, 2023

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Sep 6, 2023 •
edited
Loading

What does this PR do?

List view.name as an updatable property.

Motivation

Customer request: DataDog/browser-sdk#2396

Additional Notes

Reviewer checklist

  • Review the changed files.
  • Review the URLs listed in the Preview section.
  • Check images for PII
  • Review any mentions of "Contact Datadog support" for internal support documentation.
  • Check that cache_enabled is set to true in the pull_config_preview.yaml file

@bcaudan bcaudan requested review from a team as code owners September 6, 2023 13:14
@bcaudan bcaudan added the Do Not Merge Just do not merge this PR :) label Sep 6, 2023
@bcaudan bcaudan changed the title Browser RUM: add view.name as updatable property [RUM-1016] Browser RUM: add view.name as updatable property Sep 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Preview links (active after the build_preview check completes)

Modified Files

@bcaudan bcaudan removed the Do Not Merge Just do not merge this PR :) label Sep 13, 2023
@bcaudan
Copy link
Contributor Author

bcaudan commented Sep 13, 2023

Released in v4.49.0

@maycmlee maycmlee merged commit af110b2 into master Sep 13, 2023
@maycmlee maycmlee deleted the bcaudan/beforeSend_view.name branch September 13, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maycmlee maycmlee maycmlee approved these changes

@amortemousque amortemousque amortemousque approved these changes

@BenoitZugmeyer BenoitZugmeyer BenoitZugmeyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bcaudan @BenoitZugmeyer @amortemousque @maycmlee