-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate browser-sdk docs #17368
Merged
Merged
Migrate browser-sdk docs #17368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview links (active after the
|
bcaudan
force-pushed
the
bcaudan/internalize-browser-sdk-docs
branch
from
March 21, 2023 12:13
4c18444
to
b846a29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
💬 suggestion: maybe add our team as CODEOWNERS, so we are aware of documentation changes?
BenoitZugmeyer
approved these changes
Mar 21, 2023
amortemousque
approved these changes
Mar 21, 2023
rtrieu
approved these changes
Mar 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks Bastien.
This was referenced Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Architecture
Everything related to the Doc backend
editorial review
Waiting on a more in-depth review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Move pages from browser-sdk to documentation repository
Motivation
Initially, single source was needed to not duplicate content between rum / logs npm packages + github pages and documentation website.
As theses pages grew, we felt the need to use more concepts that are available in doc website and not in classic markdown.
The idea is then to move these pages to the doc website and have a simplistic doc on github / npm that will redirect to doc website for more content.
Additional Notes
Reviewer checklist