Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate browser-sdk docs #17368

Merged
merged 4 commits into from
Mar 28, 2023
Merged

Migrate browser-sdk docs #17368

merged 4 commits into from
Mar 28, 2023

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Mar 21, 2023

What does this PR do?

Move pages from browser-sdk to documentation repository

Motivation

Initially, single source was needed to not duplicate content between rum / logs npm packages + github pages and documentation website.
As theses pages grew, we felt the need to use more concepts that are available in doc website and not in classic markdown.
The idea is then to move these pages to the doc website and have a simplistic doc on github / npm that will redirect to doc website for more content.

Additional Notes


Reviewer checklist

  • Review the changed files.
  • Review the URLs listed in the Preview section.
  • Check images for PII
  • Review any mentions of "Contact Datadog support" for internal support documentation.

@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Mar 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 21, 2023

@bcaudan bcaudan force-pushed the bcaudan/internalize-browser-sdk-docs branch from 4c18444 to b846a29 Compare March 21, 2023 12:13
@bcaudan bcaudan marked this pull request as ready for review March 21, 2023 13:15
@bcaudan bcaudan requested review from a team as code owners March 21, 2023 13:15
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

💬 suggestion: ‏maybe add our team as CODEOWNERS, so we are aware of documentation changes?

@rtrieu rtrieu self-requested a review March 21, 2023 16:39
@alai97 alai97 added the editorial review Waiting on a more in-depth review label Mar 21, 2023
@bcaudan bcaudan requested a review from a team as a code owner March 27, 2023 16:26
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks Bastien.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend editorial review Waiting on a more in-depth review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants