Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Error Tracking custom fingerprint docs for RUM #17297

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Remove Error Tracking custom fingerprint docs for RUM #17297

merged 1 commit into from
Mar 15, 2023

Conversation

GianlucaBortoli
Copy link
Member

@GianlucaBortoli GianlucaBortoli commented Mar 15, 2023 •
edited
Loading

What does this PR do?

Remove Error Tracking custom fingerprint docs for RUM (only) because the SDK lacks support for it.
It'll be added back once we ship a fix that allows it to work as expected by reverting this PR.

Motivation

Broken functionality we shouldn't advertise while we fix the problem.

Additional Notes

Reviewer checklist

  • Review the changed files.
  • Review the URLs listed in the Preview section.
  • Check images for PII
  • Review any mentions of "Contact Datadog support" for internal support documentation.

@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Mar 15, 2023
@GianlucaBortoli GianlucaBortoli marked this pull request as ready for review March 15, 2023 09:47
@GianlucaBortoli GianlucaBortoli requested a review from a team as a code owner March 15, 2023 09:47
@github-actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

Removed or renamed files (these should redirect)

Modified Files

@bcaudan bcaudan mentioned this pull request Mar 15, 2023
Closed
@urseberry urseberry merged commit 8ef6aab into master Mar 15, 2023
@urseberry urseberry deleted the gianluca/et-custom-grouping-rum branch March 15, 2023 15:39
GianlucaBortoli added a commit that referenced this pull request May 3, 2023
@GianlucaBortoli
Revert "Temporarly remove Error Tracking custom fingerprint docs for …
2cdebee 
…RUM (#17297)"

This reverts commit 8ef6aab.
@GianlucaBortoli GianlucaBortoli mentioned this pull request May 3, 2023
Merged
alai97 added a commit that referenced this pull request May 4, 2023
@GianlucaBortoli @fdehau @alai97
[error tracking] Add custom fingerprint docs for browser RUM (#18003)
f12c74f 
* Revert "Temporarly remove Error Tracking custom fingerprint docs for RUM (#17297)"

This reverts commit 8ef6aab.

* Adjust docs to new implementation

* Fix lint

* Add minimim version for browser-sdk

* Fix typo

Co-authored-by: Florian Dehau <[email protected]>

* Better naming for custom fingerprint

* Copy Nit

* Doc Review

---------

Co-authored-by: Florian Dehau <[email protected]>
Co-authored-by: Austin Lai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urseberry urseberry urseberry approved these changes

Assignees
No one assigned
Labels
Architecture Everything related to the Doc backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GianlucaBortoli @urseberry