Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-TICKET] Ignore docs changes in system tests workflow #4318

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

Strech
Copy link
Member

@Strech Strech commented Jan 24, 2025

What does this PR do?

Ignore docs/** in system tests workflow.

Motivation:

An action item from the last guild meeting, we don't need to run whole test suite for documentation changes. This is exactly documentation-like changes.

Change log entry

No.

Additional Notes:

My auto-correction made a few adjustments for consistency, I decide to keep it.

How to test the change?

Open PR with documentation changes only, system tests should not be present. Not sure about the required checks, probably we need to configure something there too.

@Strech Strech requested a review from a team as a code owner January 24, 2025 09:13
@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Jan 24, 2025
@Strech Strech changed the title Ignore documentation changes for system tests Ignore docs changes in system tests workflow Jan 24, 2025
@Strech Strech force-pushed the change-system-tests-workflow-run-conditions branch from f2c2b98 to 02267e0 Compare January 24, 2025 09:15
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Jan 24, 2025

Datadog Report

Branch report: change-system-tests-workflow-run-conditions
Commit report: 3d9c738
Test service: dd-trace-rb

✅ 0 Failed, 22110 Passed, 1477 Skipped, 5m 20.92s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Jan 24, 2025

Benchmarks

Benchmark execution time: 2025-01-27 17:21:32

Comparing candidate commit 3d9c738 in PR branch change-system-tests-workflow-run-conditions with baseline commit 494e0e1 in branch master.

Found 1 performance improvements and 3 performance regressions! Performance is the same for 27 metrics, 2 unstable metrics.

scenario:line instrumentation - targeted

  • 🟥 throughput [-9257.463op/s; -8662.828op/s] or [-5.582%; -5.223%]

scenario:method instrumentation

  • 🟥 throughput [-11403.054op/s; -10890.332op/s] or [-6.336%; -6.051%]

scenario:profiler - stack collector

  • 🟩 throughput [+149.907op/s; +151.552op/s] or [+5.408%; +5.468%]

scenario:tracing - Propagation - Trace Context

  • 🟥 throughput [-4235.141op/s; -4147.919op/s] or [-11.162%; -10.932%]

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.73%. Comparing base (e3cec5f) to head (d51e7c5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4318   +/-   ##
=======================================
  Coverage   97.73%   97.73%           
=======================================
  Files        1367     1367           
  Lines       82864    82864           
  Branches     4209     4209           
=======================================
  Hits        80985    80985           
  Misses       1879     1879           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Strech Strech added the dev/internal Other internal work that does not need to be included in the changelog label Jan 24, 2025
@Strech Strech changed the title Ignore docs changes in system tests workflow [NO-TICKET] Ignore docs changes in system tests workflow Jan 24, 2025
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM nice!

.github/workflows/system-tests.yml Outdated Show resolved Hide resolved
@Strech Strech force-pushed the change-system-tests-workflow-run-conditions branch from 02267e0 to 227b462 Compare January 24, 2025 15:03
@Strech Strech enabled auto-merge January 24, 2025 15:04
Copy link
Member

@p-datadog p-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes since automerge is enabled.

.github/workflows/system-tests.yml Show resolved Hide resolved
.github/workflows/system-tests.yml Show resolved Hide resolved
Copy link
Member

@p-datadog p-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK sounds good.

@Strech Strech merged commit 38023b1 into master Jan 29, 2025
378 checks passed
@Strech Strech deleted the change-system-tests-workflow-run-conditions branch January 29, 2025 13:24
@github-actions github-actions bot added this to the 2.10.0 milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation dev/internal Other internal work that does not need to be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants