-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NO-TICKET] Ignore docs changes in system tests workflow #4318
Conversation
f2c2b98
to
02267e0
Compare
Datadog ReportBranch report: ✅ 0 Failed, 22110 Passed, 1477 Skipped, 5m 20.92s Total Time |
BenchmarksBenchmark execution time: 2025-01-27 17:21:32 Comparing candidate commit 3d9c738 in PR branch Found 1 performance improvements and 3 performance regressions! Performance is the same for 27 metrics, 2 unstable metrics. scenario:line instrumentation - targeted
scenario:method instrumentation
scenario:profiler - stack collector
scenario:tracing - Propagation - Trace Context
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4318 +/- ##
=======================================
Coverage 97.73% 97.73%
=======================================
Files 1367 1367
Lines 82864 82864
Branches 4209 4209
=======================================
Hits 80985 80985
Misses 1879 1879 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM nice!
02267e0
to
227b462
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes since automerge is enabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK sounds good.
What does this PR do?
Ignore
docs/**
in system tests workflow.Motivation:
An action item from the last guild meeting, we don't need to run whole test suite for documentation changes. This is exactly documentation-like changes.
Change log entry
No.
Additional Notes:
My auto-correction made a few adjustments for consistency, I decide to keep it.
How to test the change?
Open PR with documentation changes only, system tests should not be present. Not sure about the required checks, probably we need to configure something there too.