Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Datadog.configuration.appsec.rasp_enabled #4311

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

y9v
Copy link
Member

@y9v y9v commented Jan 22, 2025

What does this PR do?
It adds DD_APPSEC_RASP_ENABLED setting to AppSec for disabling RASP.

Motivation:
This RFC

Change log entry
Yes. AppSec: Add setting to disable RASP checks

Additional Notes:
None.

How to test the change?
CI is enough

@y9v y9v self-assigned this Jan 22, 2025
@y9v y9v requested a review from a team as a code owner January 22, 2025 15:40
@github-actions github-actions bot added integrations Involves tracing integrations appsec Application Security monitoring product labels Jan 22, 2025
Copy link

github-actions bot commented Jan 22, 2025

Thank you for updating Change log entry section 👏

Visited at: 2025-01-22 15:41:49 UTC

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Jan 22, 2025

Datadog Report

Branch report: appsec-add-rasp-enabled-config
Commit report: 87c14cd
Test service: dd-trace-rb

✅ 0 Failed, 22086 Passed, 1476 Skipped, 5m 2.71s Total Time

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.73%. Comparing base (97d8583) to head (d4793b5).
Report is 22 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4311      +/-   ##
==========================================
+ Coverage   97.72%   97.73%   +0.01%     
==========================================
  Files        1359     1365       +6     
  Lines       82487    82766     +279     
  Branches     4200     4205       +5     
==========================================
+ Hits        80609    80891     +282     
+ Misses       1878     1875       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jan 22, 2025

Benchmarks

Benchmark execution time: 2025-01-22 17:04:34

Comparing candidate commit 87c14cd in PR branch appsec-add-rasp-enabled-config with baseline commit d55c8cb in branch master.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics.

scenario:profiler - Allocations (profiling disabled)

  • 🟥 throughput [-439965.288op/s; -432800.143op/s] or [-8.609%; -8.469%]

scenario:profiler - Allocations (profiling enabled)

  • 🟥 throughput [-455039.691op/s; -445207.117op/s] or [-8.985%; -8.791%]

Copy link
Member

@Strech Strech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree to put it inside the instrumentation level until we find a better way to not assemble data if RASP is disabled.

It's tempting to move it into the Context.run_rasp method, but performance wise, it means we will assemble data for WAF without a need and it might be costly

@y9v y9v force-pushed the appsec-add-rasp-enabled-config branch from d4793b5 to 87c14cd Compare January 22, 2025 16:40
@marcotc
Copy link
Member

marcotc commented Jan 22, 2025

One question: what is rasp? I can't documentation for it in our source code. If one doesn't exist, can we add a short blurb explaining what is it? (anywhere is fine)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appsec Application Security monitoring product integrations Involves tracing integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants