-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Datadog.configuration.appsec.rasp_enabled #4311
base: master
Are you sure you want to change the base?
Conversation
Thank you for updating Change log entry section 👏 Visited at: 2025-01-22 15:41:49 UTC |
Datadog ReportBranch report: ✅ 0 Failed, 22086 Passed, 1476 Skipped, 5m 2.71s Total Time |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4311 +/- ##
==========================================
+ Coverage 97.72% 97.73% +0.01%
==========================================
Files 1359 1365 +6
Lines 82487 82766 +279
Branches 4200 4205 +5
==========================================
+ Hits 80609 80891 +282
+ Misses 1878 1875 -3 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2025-01-22 17:04:34 Comparing candidate commit 87c14cd in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics. scenario:profiler - Allocations (profiling disabled)
scenario:profiler - Allocations (profiling enabled)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree to put it inside the instrumentation level until we find a better way to not assemble data if RASP is disabled.
It's tempting to move it into the Context.run_rasp
method, but performance wise, it means we will assemble data for WAF without a need and it might be costly
d4793b5
to
87c14cd
Compare
One question: what is rasp? I can't documentation for it in our source code. If one doesn't exist, can we add a short blurb explaining what is it? (anywhere is fine) |
What does this PR do?
It adds
DD_APPSEC_RASP_ENABLED
setting to AppSec for disabling RASP.Motivation:
This RFC
Change log entry
Yes. AppSec: Add setting to disable RASP checks
Additional Notes:
None.
How to test the change?
CI is enough