Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-TICKET] Update README section on how to add new dependency group #4307

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

Strech
Copy link
Member

@Strech Strech commented Jan 22, 2025

What does this PR do?

Adds new section in the readme and remove duplicated section about how to add new test group into your setup, step by step.

Motivation:

I was able to do it only after the call, it makes sense to share that knowledge

Change log entry
No.

Additional Notes:

Might need some wording advice

How to test the change?

Follow instructions, and if it works - everything is correct then.

@Strech Strech requested a review from a team as a code owner January 22, 2025 10:17
@github-actions github-actions bot added the docs Involves documentation label Jan 22, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Jan 22, 2025

Datadog Report

Branch report: update-development-guide-testing-section
Commit report: 0916b42
Test service: dd-trace-rb

✅ 0 Failed, 22416 Passed, 1477 Skipped, 5m 30.27s Total Time
❄️ 1 New Flaky

New Flaky Tests (1)

  • sucker_punch instrumentation successful job instruments successful enqueuing - rspec - Last Failure

    Expand for error
     Detected invalid array contents due to unsynchronized modifications with concurrent users
     
     Failure/Error:
       traces.collect(&:spans).flatten.sort! do |a, b|
         if a.name == b.name
           if a.resource == b.resource
             if a.start_time == b.start_time
               a.end_time <=> b.end_time
             else
               a.start_time <=> b.start_time
     ...
    

@pr-commenter
Copy link

pr-commenter bot commented Jan 22, 2025

Benchmarks

Benchmark execution time: 2025-01-22 12:02:34

Comparing candidate commit 0916b42 in PR branch update-development-guide-testing-section with baseline commit 97d8583 in branch master.

Found 1 performance improvements and 2 performance regressions! Performance is the same for 28 metrics, 2 unstable metrics.

scenario:profiler - stack collector

  • 🟩 throughput [+184.874op/s; +186.903op/s] or [+6.732%; +6.805%]

scenario:tracing - 100 span trace - no writer

  • 🟥 throughput [-18.293op/s; -17.384op/s] or [-5.266%; -5.005%]

scenario:tracing - Propagation - Datadog

  • 🟥 throughput [-3235.130op/s; -3147.119op/s] or [-9.804%; -9.537%]

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.71%. Comparing base (97d8583) to head (0916b42).
Report is 22 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4307      +/-   ##
==========================================
- Coverage   97.72%   97.71%   -0.01%     
==========================================
  Files        1359     1359              
  Lines       82487    82487              
  Branches     4200     4200              
==========================================
- Hits        80609    80606       -3     
- Misses       1878     1881       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments!

docs/DevelopmentGuide.md Outdated Show resolved Hide resolved
docs/DevelopmentGuide.md Outdated Show resolved Hide resolved
docs/DevelopmentGuide.md Show resolved Hide resolved
@Strech Strech force-pushed the update-development-guide-testing-section branch 2 times, most recently from ae3a981 to 1e1e512 Compare January 22, 2025 10:58
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

* Add new section on how to add new dependency group
@Strech Strech force-pushed the update-development-guide-testing-section branch from 1e1e512 to 0916b42 Compare January 22, 2025 11:38
@Strech Strech enabled auto-merge January 22, 2025 11:38
@Strech Strech merged commit d55c8cb into master Jan 22, 2025
378 checks passed
@Strech Strech deleted the update-development-guide-testing-section branch January 22, 2025 14:00
@github-actions github-actions bot added this to the 2.10.0 milestone Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Involves documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants