-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NO-TICKET] Update README section on how to add new dependency group #4307
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 22416 Passed, 1477 Skipped, 5m 30.27s Total Time New Flaky Tests (1)
|
BenchmarksBenchmark execution time: 2025-01-22 12:02:34 Comparing candidate commit 0916b42 in PR branch Found 1 performance improvements and 2 performance regressions! Performance is the same for 28 metrics, 2 unstable metrics. scenario:profiler - stack collector
scenario:tracing - 100 span trace - no writer
scenario:tracing - Propagation - Datadog
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4307 +/- ##
==========================================
- Coverage 97.72% 97.71% -0.01%
==========================================
Files 1359 1359
Lines 82487 82487
Branches 4200 4200
==========================================
- Hits 80609 80606 -3
- Misses 1878 1881 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments!
ae3a981
to
1e1e512
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
* Add new section on how to add new dependency group
1e1e512
to
0916b42
Compare
What does this PR do?
Adds new section in the readme and remove duplicated section about how to add new test group into your setup, step by step.
Motivation:
I was able to do it only after the call, it makes sense to share that knowledge
Change log entry
No.
Additional Notes:
Might need some wording advice
How to test the change?
Follow instructions, and if it works - everything is correct then.