Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update supported versions workflow #4289

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

quinna-h
Copy link
Contributor

@quinna-h quinna-h commented Jan 14, 2025

What does this PR do?

Update supported versions workflow from #4210
There was a bug with not correctly parsing lines such as gem "rest-client", which should be treated as using latest.
Additionally, fix hardcoded versions for makara httpx

Motivation:

Change log entry
None

Additional Notes:

How to test the change?

@quinna-h quinna-h requested a review from a team as a code owner January 14, 2025 20:23
Copy link

github-actions bot commented Jan 14, 2025

Thank you for updating Change log entry section 👏

Visited at: 2025-01-15 14:40:38 UTC

@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Jan 14, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Jan 14, 2025

Datadog Report

Branch report: quinna/update-supported-versions-workflow
Commit report: bee97cc
Test service: dd-trace-rb

✅ 0 Failed, 22195 Passed, 1476 Skipped, 5m 14.44s Total Time

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.71%. Comparing base (b2bf14b) to head (bee97cc).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4289      +/-   ##
==========================================
- Coverage   97.71%   97.71%   -0.01%     
==========================================
  Files        1355     1355              
  Lines       82434    82434              
  Branches     4213     4213              
==========================================
- Hits        80553    80548       -5     
- Misses       1881     1886       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jan 14, 2025

Benchmarks

Benchmark execution time: 2025-01-14 20:45:52

Comparing candidate commit bee97cc in PR branch quinna/update-supported-versions-workflow with baseline commit b2bf14b in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@marcotc marcotc merged commit e28dcc8 into master Jan 14, 2025
385 checks passed
@marcotc marcotc deleted the quinna/update-supported-versions-workflow branch January 14, 2025 22:09
@github-actions github-actions bot added this to the 2.9.0 milestone Jan 14, 2025
p-datadog pushed a commit that referenced this pull request Jan 15, 2025
* master: (161 commits)
  Bump to version 2.9.0 (#4293)
  Increase type checking coverage (#4290)
  DEBUG-3329 rename datadog/di/init to datadog/di/preload (#4288)
  update supported versions workflow (#4289)
  DEBUG-3182 DI railtie (#4272)
  DEBUG-3328 report DI status in environment logger summary (#4285)
  Move out ostruct gem from test group for Ruby 3.5
  DEBUG-3316 verify code tracking works in forked processes (#4284)
  Fix rebase issue in Rack::RequestMiddleware
  Improve code style in AppSec rack middlewares
  Improve variable naming in Rack::RequestBodyMiddleware
  Improve variable naming in Rack::RequestMiddleware
  Simplify Rack::RequestMiddleware
  Switch AppSec rack blocking to throw
  Extract to .gitlab/scripts
  Implement polling vaccine
  Update RBS signatures
  Add new RSpec negate matcher not_change
  Replace direct AppSec::Processor::Context calls
  Change AppSec::Context exposed interface
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants