Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🤖] Update Latest Dependency #4241

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

TonyCTHsu
Copy link
Contributor

This is an auto-generated PR from here, which creates a pull request that will be continually updated with new changes until it is merged or closed)

The PR updates latest versions of defined dependencies. Please review the changes and merge when ready.

@TonyCTHsu TonyCTHsu requested a review from a team as a code owner December 22, 2024 00:16
@TonyCTHsu TonyCTHsu added dev/internal Other internal work that does not need to be included in the changelog integrations Involves tracing integrations labels Dec 22, 2024
@TonyCTHsu TonyCTHsu enabled auto-merge December 22, 2024 00:16
Copy link

👋 Hey @DataDog/ruby-guild, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2024-12-22 00:16:53 UTC

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Dec 22, 2024

Datadog Report

Branch report: auto-generate/update-latest-dependencies
Commit report: 1ac1146
Test service: dd-trace-rb

❌ 15 Failed (0 Known Flaky), 22127 Passed, 1471 Skipped, 5m 34.48s Total Time
❄️ 49 New Flaky

❌ Failed Tests (15)

This report shows up to 5 failed tests.

  • Rails cache #delete - rspec - Details

    Expand for error
     undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
     
     Failure/Error: initialize!
     
     NoMethodError:
       undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
     /usr/local/bundle/gems/actionview-6.1.7.10/lib/action_view/railtie.rb:17:in 'block in <class:Railtie>'
     /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:68:in 'block in ActiveSupport::LazyLoadHooks#execute_hook'
     /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:61:in 'ActiveSupport::LazyLoadHooks#with_execution_control'
     /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:66:in 'ActiveSupport::LazyLoadHooks#execute_hook'
     ...
    
  • Rails cache #delete when cache_key.enabled is false - rspec - Details

    Expand for error
     undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
     
     Failure/Error: initialize!
     
     NoMethodError:
       undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
     /usr/local/bundle/gems/actionview-6.1.7.10/lib/action_view/railtie.rb:17:in 'block in <class:Railtie>'
     /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:68:in 'block in ActiveSupport::LazyLoadHooks#execute_hook'
     /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:61:in 'ActiveSupport::LazyLoadHooks#with_execution_control'
     /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:66:in 'ActiveSupport::LazyLoadHooks#execute_hook'
     ...
    
  • Rails cache #fetch_multi when the method is defined with exception - rspec - Details

    Expand for error
     undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
     
     Failure/Error: initialize!
     
     NoMethodError:
       undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
     /usr/local/bundle/gems/actionview-6.1.7.10/lib/action_view/railtie.rb:17:in 'block in <class:Railtie>'
     /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:68:in 'block in ActiveSupport::LazyLoadHooks#execute_hook'
     /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:61:in 'ActiveSupport::LazyLoadHooks#with_execution_control'
     /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:66:in 'ActiveSupport::LazyLoadHooks#execute_hook'
     ...
    
  • Rails cache #fetch_multi when the method is defined with exception and when cache_key.enabled is false - rspec

  • Rails cache #fetch_multi when the method is not defined - rspec - Details

    Expand for error
     undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
     
     Failure/Error: initialize!
     
     NoMethodError:
       undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
     /usr/local/bundle/gems/actionview-6.1.7.10/lib/action_view/railtie.rb:17:in 'block in <class:Railtie>'
     /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:68:in 'block in ActiveSupport::LazyLoadHooks#execute_hook'
     /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:61:in 'ActiveSupport::LazyLoadHooks#with_execution_control'
     /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:66:in 'ActiveSupport::LazyLoadHooks#execute_hook'
     ...
    

New Flaky Tests (49)

  • Rails cache #delete behaves like an instrumented cache method behaves like measured span for integration does not set _dd.measured on the span - rspec - Last Failure

    Expand for error
     undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
     
     Failure/Error: initialize!
     
     NoMethodError:
       undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
     Shared Example Group: "measured span for integration" called from ./spec/datadog/tracing/contrib/rails/cache_spec.rb:84
     Shared Example Group: "an instrumented cache method" called from ./spec/datadog/tracing/contrib/rails/cache_spec.rb:329
     /usr/local/bundle/gems/actionview-6.1.7.10/lib/action_view/railtie.rb:17:in 'block in <class:Railtie>'
     /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:68:in 'block in ActiveSupport::LazyLoadHooks#execute_hook'
     ...
    
  • Rails cache #delete behaves like an instrumented cache method disabled at integration level does not instrument - rspec - Last Failure

    Expand for error
     undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
     
     Failure/Error: initialize!
     
     NoMethodError:
       undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
     Shared Example Group: "an instrumented cache method" called from ./spec/datadog/tracing/contrib/rails/cache_spec.rb:329
     /usr/local/bundle/gems/actionview-6.1.7.10/lib/action_view/railtie.rb:17:in 'block in <class:Railtie>'
     /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:68:in 'block in ActiveSupport::LazyLoadHooks#execute_hook'
     /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:61:in 'ActiveSupport::LazyLoadHooks#with_execution_control'
     ...
    
  • Rails cache #delete behaves like an instrumented cache method disabled at tracer level does not instrument - rspec - Last Failure

    Expand for error
     undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
     
     Failure/Error: initialize!
     
     NoMethodError:
       undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
     Shared Example Group: "an instrumented cache method" called from ./spec/datadog/tracing/contrib/rails/cache_spec.rb:329
     /usr/local/bundle/gems/actionview-6.1.7.10/lib/action_view/railtie.rb:17:in 'block in <class:Railtie>'
     /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:68:in 'block in ActiveSupport::LazyLoadHooks#execute_hook'
     /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:61:in 'ActiveSupport::LazyLoadHooks#with_execution_control'
     ...
    
  • Rails cache #delete behaves like an instrumented cache method with a cache different from Rails' default store returns the matching backend type - rspec - Last Failure

    Expand for error
     undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
     
     Failure/Error: initialize!
     
     NoMethodError:
       undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
     Shared Example Group: "an instrumented cache method" called from ./spec/datadog/tracing/contrib/rails/cache_spec.rb:329
     /usr/local/bundle/gems/actionview-6.1.7.10/lib/action_view/railtie.rb:17:in 'block in <class:Railtie>'
     /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:68:in 'block in ActiveSupport::LazyLoadHooks#execute_hook'
     /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:61:in 'ActiveSupport::LazyLoadHooks#with_execution_control'
     ...
    
  • Rails cache #delete behaves like an instrumented cache method with a cache not in the ActiveSupport::Cache:: namespace returns the matching backend type - rspec - Last Failure

    Expand for error
     undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
     
     Failure/Error: initialize!
     
     NoMethodError:
       undefined method 'embed_authenticity_token_in_remote_forms=' for module ActionView::Helpers::FormTagHelper
     Shared Example Group: "an instrumented cache method" called from ./spec/datadog/tracing/contrib/rails/cache_spec.rb:329
     /usr/local/bundle/gems/actionview-6.1.7.10/lib/action_view/railtie.rb:17:in 'block in <class:Railtie>'
     /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:68:in 'block in ActiveSupport::LazyLoadHooks#execute_hook'
     /usr/local/bundle/gems/activesupport-6.1.7.10/lib/active_support/lazy_load_hooks.rb:61:in 'ActiveSupport::LazyLoadHooks#with_execution_control'
     ...
    

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (c116d75) to head (106b54f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4241      +/-   ##
==========================================
+ Coverage   97.75%   97.76%   +0.01%     
==========================================
  Files        1355     1355              
  Lines       82366    82365       -1     
  Branches     4230     4230              
==========================================
+ Hits        80514    80522       +8     
+ Misses       1852     1843       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Dec 22, 2024

Benchmarks

Benchmark execution time: 2024-12-29 00:40:27

Comparing candidate commit 1ac1146 in PR branch auto-generate/update-latest-dependencies with baseline commit 44f36d3 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@TonyCTHsu TonyCTHsu force-pushed the auto-generate/update-latest-dependencies branch from 106b54f to 1ac1146 Compare December 29, 2024 00:16
@TonyCTHsu TonyCTHsu merged commit cf5120d into master Dec 30, 2024
342 of 346 checks passed
@TonyCTHsu TonyCTHsu deleted the auto-generate/update-latest-dependencies branch December 30, 2024 10:38
@github-actions github-actions bot added this to the 2.9.0 milestone Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/internal Other internal work that does not need to be included in the changelog integrations Involves tracing integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants