DEBUG-2334 DI: method probes: pass block to target method when rate limited

[p-datadog]

What does this PR do?

Fixes a bug in dynamic instrumentation where once a method was instrumented with a method probe and the rate limit for the probe was reached, the block would not be passed to target method from DI.

Motivation:

Code inspection when implementing snapshot benchmarks (#4207).

Change log entry

No.

Additional Notes:

Reason: while this issue would have affected customer applications, DI has not yet been shipped.

I added many tests but could not yet reproduce the scenario where the separated calls to super were necessary as they are in the non-rate limited path. I added the separated calls in case they are indeed required.

How to test the change?

Unit tests are included.

[github-actions]

👋 Hey @Strech, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

^{Visited at: 2024-12-10 10:05:59 UTC}

[pr-commenter]

Benchmarks

Benchmark execution time: 2024-12-09 14:35:22

Comparing candidate commit c7ab921 in PR branch di-rate-limit-block with baseline commit c07a8d4 in branch master.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics.

scenario:tracing - 100 span trace - no writer

• 🟩 throughput [+17.670op/s; +18.572op/s] or [+5.324%; +5.596%]

scenario:tracing - Propagation - Trace Context

• 🟩 throughput [+4199.193op/s; +4298.031op/s] or [+12.325%; +12.616%]

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 96.29630% with 6 lines in your changes missing coverage. Please review.

Project coverage is 97.76%. Comparing base (c07a8d4) to head (c7ab921).
Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
spec/datadog/di/instrumenter_spec.rb	97.16%	4 Missing ⚠️
lib/datadog/di/instrumenter.rb	87.50%	1 Missing ⚠️
spec/datadog/di/hook_method.rb	92.30%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4206      +/-   ##
==========================================
- Coverage   97.77%   97.76%   -0.01%     
==========================================
  Files        1357     1357              
  Lines       81973    82120     +147     
  Branches     4168     4174       +6     
==========================================
+ Hits        80145    80285     +140     
- Misses       1828     1835       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.