-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not load redis
gem when incompatible
#4197
Conversation
Thank you for updating Change log entry section 👏 Visited at: 2024-12-06 08:52:51 UTC |
633434a
to
fe211f7
Compare
BenchmarksBenchmark execution time: 2024-12-06 19:52:29 Comparing candidate commit 3e5346a in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics. scenario:line instrumentation - targeted
scenario:profiler - sample timeline=false
|
fe211f7
to
f025594
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4197 +/- ##
==========================================
- Coverage 97.77% 97.76% -0.01%
==========================================
Files 1357 1357
Lines 81971 81974 +3
Branches 4168 4168
==========================================
- Hits 80147 80145 -2
- Misses 1824 1829 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM -- really nice catch!
When this will be released under new tag? |
Hey @kayn1 this will be part of the next version (2.8.0), which we plan on publishing this week |
Change log entry
Yes. Avoids loading
ActiveSupport::Cache::RedisCacheStore
, which tries to loadredis >= 4.0.1
regardless of the version of Redis the host application has installed.Additional Notes:
How to test the change?
There are automated tests in this PR, by running the Rails cache tests with an older Redis.