Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not load redis gem when incompatible #4197

Merged
merged 6 commits into from
Dec 6, 2024
Merged

Do not load redis gem when incompatible #4197

merged 6 commits into from
Dec 6, 2024

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Dec 5, 2024

Change log entry
Yes. Avoids loading ActiveSupport::Cache::RedisCacheStore, which tries to load redis >= 4.0.1 regardless of the version of Redis the host application has installed.

Additional Notes:

How to test the change?
There are automated tests in this PR, by running the Rails cache tests with an older Redis.

@marcotc marcotc requested review from a team as code owners December 5, 2024 23:56
@marcotc marcotc self-assigned this Dec 5, 2024
Copy link

github-actions bot commented Dec 5, 2024

Thank you for updating Change log entry section 👏

Visited at: 2024-12-06 08:52:51 UTC

@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Dec 5, 2024
@marcotc marcotc added bug Involves a bug and removed integrations Involves tracing integrations labels Dec 5, 2024
@github-actions github-actions bot added the integrations Involves tracing integrations label Dec 6, 2024
@pr-commenter
Copy link

pr-commenter bot commented Dec 6, 2024

Benchmarks

Benchmark execution time: 2024-12-06 19:52:29

Comparing candidate commit 3e5346a in PR branch fix-redis-load with baseline commit 0ccc150 in branch master.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics.

scenario:line instrumentation - targeted

  • 🟩 throughput [+9153.716op/s; +9776.712op/s] or [+5.896%; +6.297%]

scenario:profiler - sample timeline=false

  • 🟩 throughput [+0.566op/s; +0.581op/s] or [+9.443%; +9.696%]

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (0ccc150) to head (3e5346a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4197      +/-   ##
==========================================
- Coverage   97.77%   97.76%   -0.01%     
==========================================
  Files        1357     1357              
  Lines       81971    81974       +3     
  Branches     4168     4168              
==========================================
- Hits        80147    80145       -2     
- Misses       1824     1829       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM -- really nice catch!

@marcotc marcotc enabled auto-merge December 6, 2024 18:56
@marcotc marcotc added this to the 2.8.0 milestone Dec 6, 2024
@marcotc marcotc merged commit 7a544cd into master Dec 6, 2024
351 checks passed
@marcotc marcotc deleted the fix-redis-load branch December 6, 2024 19:53
@kayn1
Copy link

kayn1 commented Dec 9, 2024

When this will be released under new tag?

@ivoanjo
Copy link
Member

ivoanjo commented Dec 9, 2024

Hey @kayn1 this will be part of the next version (2.8.0), which we plan on publishing this week

@ivoanjo ivoanjo mentioned this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Involves a bug integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants