-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement latest_major
and lastest_minor
tag for docker init container
#3643
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
#!/usr/bin/env ruby | ||
|
||
require 'bundler/inline' | ||
|
||
gemfile { gem 'gems', source: 'https://rubygems.org' } | ||
|
||
require 'rubygems' | ||
require 'gems' | ||
|
||
version = ARGV[0].chomp | ||
version = version.delete_prefix('v') if version.start_with?('v') | ||
|
||
candidate = Gem::Version.new(version) | ||
|
||
retry_count = 0 | ||
max_retries = 60 | ||
interval = 60 | ||
|
||
loop do | ||
versions = Gems.versions('datadog').map { |h| Gem::Version.new(h['number']) } | ||
|
||
if versions.include?(candidate) | ||
puts "Gem version #{candidate} found!" | ||
exit 0 | ||
else | ||
retry_count += 1 | ||
puts "Attempt(#{retry_count}): Gem 'datadog' version '#{candidate}' not found." | ||
|
||
if retry_count >= max_retries | ||
puts "Max retries(#{max_retries}) reached, stopping..." | ||
exit 1 | ||
else | ||
puts "Retrying in #{interval} seconds..." | ||
sleep interval | ||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
#!/usr/bin/env ruby | ||
|
||
require 'bundler/inline' | ||
|
||
gemfile { gem 'gems', source: 'https://rubygems.org' } | ||
|
||
require 'rubygems' | ||
require 'gems' | ||
|
||
image_name = ARGV[0].chomp | ||
version = ARGV[1].chomp | ||
version = version.delete_prefix('v') if version.start_with?('v') | ||
|
||
candidate = Gem::Version.new(version) | ||
versions = Gems.versions('datadog').map { |h| Gem::Version.new(h['number']) } | ||
|
||
# Make sure candidate has already been published to 'https://rubygems.org' | ||
unless versions.include?(candidate) | ||
warn "Version #{candidate} not found in RubyGems" | ||
exit 1 | ||
end | ||
|
||
# Skip pre-releases | ||
if candidate.prerelease? | ||
warn 'No tags for pre-releases' | ||
exit 1 | ||
end | ||
|
||
major, minor, = candidate.to_s.split('.') | ||
current_major_versions = versions.select { |v| v.to_s.start_with?("#{major}.") } | ||
|
||
tags = [] | ||
|
||
tags << 'latest' if versions.all? { |v| candidate >= v } | ||
tags << "v#{major}" if current_major_versions.all? { |v| candidate >= v } | ||
tags << "v#{major}.#{minor}" | ||
tags << "v#{candidate}" | ||
|
||
# $stdout.puts "tags: #{tags}" # Uncomment for debugging | ||
|
||
destinations = tags.map { |tag| "#{image_name}:#{tag}" } | ||
$stdout.puts destinations.join(',') |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need wait a whole minute before retrying?
I ask in case
.gitlab/check_gem_presence.rb
is ever something a human is actively waiting on. If so, I suggest reducing the interval to something like 10 seconds (and increasingmax_retries
to match).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can change this frequency in the future.