[NO-TICKET] Remove deprecated profiler settings #3597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** This profiler removes a number of profiler settings that have been deprecated for a while. **Motivation:** On the 1.x series, we were keeping these settings around, even though they didn't do anything; for the 2.0 release, we're taking the opportunity to delete them, as, again, they don't do anything. **Additional Notes:** I've included the needed changes to the upgrade guide as well. **How to test the change?** These settings were already not in use, so the only change is really to delete any references to them.
github-actions
bot
added
core
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.0 #3597 +/- ##
==========================================
- Coverage 98.09% 98.08% -0.01%
==========================================
Files 1219 1220 +1
Lines 71603 71863 +260
Branches 3406 3412 +6
==========================================
+ Hits 70237 70486 +249
- Misses 1366 1377 +11 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This profiler removes a number of profiler settings that have been deprecated for a while.
Motivation:
On the 1.x series, we were keeping these settings around, even though they didn't do anything; for the 2.0 release, we're taking the opportunity to delete them, as, again, they don't do anything.
Additional Notes:
I've included the needed changes to the upgrade guide as well.
How to test the change?
These settings were already not in use, so the only change is really to delete any references to them.