Backport "Reduce startup logs verbosity" to master #3468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This saves us a few characters in most timezones and as a bonus the output is consistent regardless of local system configuration.
This field allows extra stuff to be added without having to print separate lines and/or have a separate environment logger.
…rate log line The profiling logger was very minimal, so by doing this change we enable components to return values to be included in the core logger.
github-actions
bot
added
core
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3468 +/- ##
==========================================
- Coverage 98.23% 98.23% -0.01%
==========================================
Files 1277 1275 -2
Lines 75141 75084 -57
Branches 3544 3546 +2
==========================================
- Hits 73817 73760 -57
Misses 1324 1324 ☔ View full report in Codecov by Sentry. |
AlexJF
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR backports #3448 "[NO-TICKET] Reduce startup logs verbosity" from the 2.0 branch to master.
Motivation:
This change slightly reduces the amount of logging ddtrace does (see original PR), as well as makes sure our 1.x and 2.x logging are aligned.
Additional Notes:
N/A
How to test the change?
You can use for instance
to see the difference.
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.