Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP adapter renamed to :http #3406

Closed
wants to merge 1 commit into from
Closed

HTTP adapter renamed to :http #3406

wants to merge 1 commit into from

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Jan 25, 2024

2.0 Upgrade Guide notes

In 1.x:

c.tracing.transport_options = proc do |t|
  t.adapter :net_http
end

In 2.0:

c.tracing.transport_options = proc do |t|
  t.adapter :http
end

Motivation:

The fact that the HTTP transport currently uses Net::HTTP is an implementation detail.

Additional Notes:

How to test the change?

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@marcotc marcotc requested review from a team as code owners January 25, 2024 22:23
@github-actions github-actions bot added the core Involves Datadog core libraries label Jan 25, 2024
@ivoanjo
Copy link
Member

ivoanjo commented Jan 26, 2024

Hey, I think PR's upgrade notes description is off, since c.tracing.transport_options has been removed in #3350 🤔

@ekump
Copy link
Contributor

ekump commented Jan 26, 2024

Hey, I think PR's upgrade notes description is off, since c.tracing.transport_options has been removed in #3350 🤔

@ivoanjo is correct. Users can no longer explicitly set an adapter anymore.

Copy link
Contributor

@ekump ekump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not to be pedantic, but I wonder if http is accurate enough since UDS also technically uses http? Perhaps sticking with http is necessary for consistency with other tracers and other datadog docs, so not blocking an LGTM from me.

@marcotc marcotc closed this Jan 26, 2024
@marcotc
Copy link
Member Author

marcotc commented Jan 26, 2024

This change is not really important, so I'll just remove the possibly inaccurate comment instead #3411

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Involves Datadog core libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants