Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add base64 gem #3364

Merged
merged 1 commit into from
Jan 15, 2024
Merged

add base64 gem #3364

merged 1 commit into from
Jan 15, 2024

Conversation

amancevice
Copy link
Contributor

@amancevice amancevice commented Jan 4, 2024 •
edited
Loading

2.0 Upgrade Guide notes

What does this PR do?

Adds base64 to the gemspec

Motivation:

Requiring base64 from stdlib is deprecated in Ruby v3.3 and will be removed in v3.4

Additional Notes:

N/A

How to test the change?

N/A (drop-in replacement)

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@amancevice amancevice requested a review from a team as a code owner January 4, 2024 20:18
@marcotc
Copy link
Member

marcotc commented Jan 5, 2024

Thank you very much, @amancevice!

Could you please rebase this change to the branch 2.0? The gem base64 is not available for Ruby < 2.3.0, thus CI will not pass on the master branch. But on the branch 2.0, we removed support Ruby < 2.5, thus your PR will work with no issues.

@amancevice
add base64 gem
adc44db 
base64 is deprecated in Ruby v3.3 and will be removed in v3.4
@amancevice amancevice requested review from a team as code owners January 6, 2024 02:46
@github-actions github-actions bot added appsec Application Security monitoring product core Involves Datadog core libraries integrations Involves tracing integrations tracing labels Jan 6, 2024
@amancevice amancevice changed the base branch from master to 2.0 January 6, 2024 02:46
@amancevice
Copy link
Contributor Author

@marcotc done!

@marcotc marcotc removed appsec Application Security monitoring product integrations Involves tracing integrations tracing labels Jan 15, 2024
@marcotc marcotc merged commit 50bce97 into DataDog:2.0 Jan 15, 2024
40 checks passed
@TonyCTHsu TonyCTHsu added this to the 2.0 milestone Feb 20, 2024
@ivoanjo ivoanjo added the 2.0 label Mar 14, 2024
@TonyCTHsu TonyCTHsu modified the milestones: 2.0, 2.0.0.beta1 Mar 22, 2024
Earlopain added a commit to Earlopain/dd-trace-rb that referenced this pull request Mar 27, 2024
@Earlopain
Remove dependency on base64 gem
f815591 
Added in DataDog#3364. It's just a simple wrapper, so it's trivial to inline.

Add a new module to keep keep descriptive method names
@Earlopain Earlopain mentioned this pull request Mar 27, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brett0000FF brett0000FF brett0000FF approved these changes

Assignees
No one assigned
Labels
2.0 core Involves Datadog core libraries
Projects
None yet
Milestone
2.0.0.beta1
Development

Successfully merging this pull request may close these issues.
5 participants
@amancevice @marcotc @brett0000FF @ivoanjo @TonyCTHsu