AppSec check for remote configuration content rather than relay on product path #2822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lloeki
requested changes
Apr 28, 2023
Make sure to handle product updates properly. There is no warranty that a product update will only contain a single product key. In the case of `ASM` product, the schema allows for multiple keys: `rules_override`, and `exclusions` In that case we should make sure that we properly extract each product information orrectly. That way the RuleMerger can combine all the information correctly. Since we have modify the content that we pass to the RulerMerger we had to modify a little its code.
GustavoCaso
force-pushed
the
remote-properly-parse-asm-product-updates
branch
from
e95cee0 to
c8f22aa
Compare
GustavoCaso
changed the title
GustavoCaso
force-pushed
the
remote-properly-parse-asm-product-updates
branch
from
ce56bde to
c8f22aa
Compare
lloeki
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Make sure to handle product updates properly. Using the product update content
to distinguish it rather than using the content
config_idThere is no warranty that a product update will only contain a single
product key.
In the case of
ASMproduct, the schema allows for multiple keys:rules_override, andexclusionsIn that case, we should ensure we extract
each product information correctly. That way, the
RuleMergercan combineall the information correctly.
Since we have modified the content that we pass to the
RuleMerger.Removing the top-level keys
rules_data,rules_override, andexclusionswe had to modify its code. Same for
RuleLoaderto make sureload_datareturns data in a format
RuleMergerunderstand.Motivation
Additional Notes
How to test the change?