[APPSEC-6712] Remote configuration config_state
#2794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GustavoCaso
changed the title
config_state
GustavoCaso
force-pushed
the
remote-populate-config-states
branch
from
ca8fe4e to
9313881
Compare
lloeki
approved these changes
Apr 17, 2023
lloeki
reviewed
Apr 17, 2023
| @@ -48,16 +48,18 @@ class << self | |||
| def parse(hash) | |||
| length = Integer(hash['length']) | |||
| digests = Configuration::DigestList.parse(hash['hashes']) | |||
| version = Integer(hash['custom']['v']) | |||
There was a problem hiding this comment.
This is failing:
NoMethodError:
undefined method `[]' for nil:NilClass
# ./lib/datadog/core/remote/configuration/target.rb:51:in `parse'
# ./spec/datadog/core/remote/configuration/target_spec.rb:178:in `block (3 levels) in <top (required)>'
# ./spec/datadog/core/remote/configuration/target_spec.rb:199:in `block (5 levels) in <top (required)>'
Populate config_states
GustavoCaso
force-pushed
the
remote-populate-config-states
branch
from
9313881 to
725210a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Stores and set remote configuration content version. Is that information to populate the client
config_state@lloeki will work on the remaining portion of
config_state, which is adding the information if any error occurred during the remote configuration syncMotivation
Additional Notes
Here are the system test assertions on the expected values for
config_statesHow to test the change?
CI