[APPSEC-8867] Appsec reuse rules when ASM_DD is empty #2732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
appsec
GustavoCaso
force-pushed
the
appsec-reuse-rules-when-asm-dd-is-empty
branch
from
65d818d to
45dd5d0
Compare
GustavoCaso
commented
Mar 30, 2023
Comment on lines
+210
to
+220
| repository.contents.each do |content| | ||
| case content.path.product | ||
| when 'ASM_DD' | ||
| rules << parse_content(content) | ||
| when 'ASM_DATA' | ||
| data << parse_content(content) if asm_data_config_types.include?(content.path.config_id) | ||
| when 'ASM' | ||
| overrides << parse_content(content) if asm_overrides_config_types.include?(content.path.config_id) | ||
| exclusions << parse_content(content) if content.path.config_id == 'exclusion_filters' | ||
| end | ||
| end |
There was a problem hiding this comment.
This reduces the time we iterate over repository.contents from 4 to 1.
Codecov Report
@@ Coverage Diff @@
## master #2732 +/- ##
=======================================
Coverage 98.05% 98.06%
=======================================
Files 1212 1214 +2
Lines 66643 66716 +73
Branches 2991 3002 +11
=======================================
+ Hits 65350 65425 +75
+ Misses 1293 1291 -2
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lloeki
approved these changes
Mar 30, 2023
| @@ -64,18 +63,18 @@ class AlreadyActiveContextError < StandardError; end | |||
|
|
|||
| attr_reader :ruleset_info, :addresses | |||
|
|
|||
| def initialize(ruleset: nil) | |||
| def initialize(ruleset:) | |||
There was a problem hiding this comment.
Cool, I was thinking of getting rid of that nilable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
During Remote Client sync, there could be occasions when the rules information from
ASM_DDproduct is not present or not available.In those situations, we should default to the ones defined on the appsec settings. By default is
:recommendedAdditional Notes
I had to extract away the parsing of the ruleset from the
AppSec::Processor, so I could reuse it in other places in the code base. I like it because it removes that functionality fromProcessor, which is only responsible for ensuring a valid processor and context are created, with therulesetprovided.How to test the change?
CI