[PROF-6838] Upgrade to libdatadog 1.0.1.1.0 #2530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?**: Upgrade dd-trace-rb to use the latest libdatadog release (1.0.1.1.0). This libdatadog release includes: * A number of API renames (documented in <DataDog/libdatadog#73>) * The addition of `endpoint_counts`, which we don't use yet, but that needed a few additional changes to API calls and specs. **Motivation**: Keep up with latest improvements and features being added to libdatadog. **Additional Notes**: I've skipped packaging the libdatadog 1.0.0 release, and we're going straight to 1.0.1. **How to test the change?**: The changes in this PR are already covered by the existing tests.
ivoanjo
changed the title
ivoanjo
added a commit
to DataDog/libdatadog
that referenced
this pull request
Jan 6, 2023
**What does this PR do?**: Package libdatadog 1.0.1 for Ruby. **Motivation**: Use latest libdatadog version from Ruby. **Additional Notes**: The 1.0.0 release was never packaged, and I don't think it's worth doing so just for completeness. (The binaries are still up on GitHub, so this decision can be revisited if ever we change our minds). I'm following along the checklist at <https://github.com/DataDog/libdatadog/blob/main/ruby/README.md#releasing-a-new-version-to-rubygemsorg> **How to test the change?**: I have an open draft PR to integrate this release into the Ruby profiler: DataDog/dd-trace-rb#2530 . The downstream Ruby integration does not pick up new releases automatically. To test this locally, you'll need to download package the gem manually, and then install it and you'll be able to run the dd-trace-rb test suite using the draft branch above.
ivoanjo
added a commit
to DataDog/libdatadog
that referenced
this pull request
Jan 6, 2023
**What does this PR do?**: Package libdatadog 1.0.1 for Ruby. **Motivation**: Use latest libdatadog version from Ruby. **Additional Notes**: The 1.0.0 release was never packaged, and I don't think it's worth doing so just for completeness. (The binaries are still up on GitHub, so this decision can be revisited if ever we change our minds). I'm following along the checklist at <https://github.com/DataDog/libdatadog/blob/main/ruby/README.md#releasing-a-new-version-to-rubygemsorg> **How to test the change?**: I have an open draft PR to integrate this release into the Ruby profiler: DataDog/dd-trace-rb#2530 . The downstream Ruby integration does not pick up new releases automatically. To test this locally, you'll need to download package the gem manually, and then install it and you'll be able to run the dd-trace-rb test suite using the draft branch above.
Codecov Report
@@ Coverage Diff @@
## master #2530 +/- ##
==========================================
+ Coverage 98.31% 98.32% +0.01%
==========================================
Files 1124 1124
Lines 60657 60660 +3
==========================================
+ Hits 59635 59645 +10
+ Misses 1022 1015 -7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Marked PR as ready for review :) |
marcotc
approved these changes
Jan 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Upgrade dd-trace-rb to use the latest libdatadog release (1.0.1.1.0).
This libdatadog release includes:
endpoint_counts, which we don't use yet, but that needed a few additional changes to API calls and specs.Motivation:
Keep up with latest improvements and features being added to libdatadog.
Additional Notes:
I've skipped packaging the libdatadog 1.0.0 release, and we're going straight to 1.0.1.
I'm opening this PR as a draft because libdatadog 1.0.1.1.0 has not yet been published to rubygems (hence our CI failing with this PR). Once I've published it, I'll re-trigger CI and remove the draft label with no further changes.Update: Published, and dropped draft label.How to test the change?:
The changes in this PR are already covered by the existing tests.