Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

writer thread safety #1091

Merged
merged 2 commits into from
Jul 7, 2020
Merged

writer thread safety #1091

merged 2 commits into from
Jul 7, 2020

Conversation

fledman
Copy link
Contributor

@fledman fledman commented Jun 22, 2020

resolves #1063
tangentially related to #1072

@marcotc @delner
feel free to make additional changes

@fledman fledman requested a review from a team June 22, 2020 21:55
marcotc
marcotc approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@marcotc marcotc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your patience @fledman, the PR looks good, awesome work! 👍

@marcotc marcotc added community Was opened by a community member bug Involves a bug labels Jul 7, 2020
@marcotc marcotc merged commit 16643b9 into DataDog:master Jul 7, 2020
@fledman fledman deleted the writer_thread_safety branch July 7, 2020 19:28
@marcotc marcotc added this to the 0.38.0 milestone Jul 7, 2020
@marcotc marcotc mentioned this pull request Jul 8, 2020
Merged
@cjford cjford mentioned this pull request Nov 5, 2020
Closed
@marcotc marcotc mentioned this pull request Nov 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcotc marcotc marcotc approved these changes

Assignees

@fledman fledman

Labels
bug Involves a bug community Was opened by a community member
Projects
None yet
Milestone
0.38.0
Development

Successfully merging this pull request may close these issues.

thread safety issue with Writer
2 participants
@fledman @marcotc