Merge pull request #2896 from DataDog/tonycthsu/fix-aws-integration-c…

…onstant-loading Fix AWS integration constant loading
DataDog · Jun 7, 2023 · d3bdba5 · d3bdba5
2 parents 62a7a8d + e8d5154
commit d3bdba5
Show file tree

Hide file tree

Showing 19 changed files with 85 additions and 26 deletions.
diff --git a/lib/datadog/tracing/contrib/aws/service/dynamodb.rb b/lib/datadog/tracing/contrib/aws/service/dynamodb.rb
@@ -1,5 +1,8 @@
 # frozen_string_literal: true
 
+require_relative './base'
+require_relative '../ext'
+
 module Datadog
   module Tracing
     module Contrib

diff --git a/lib/datadog/tracing/contrib/aws/service/eventbridge.rb b/lib/datadog/tracing/contrib/aws/service/eventbridge.rb
@@ -1,5 +1,8 @@
 # frozen_string_literal: true
 
+require_relative './base'
+require_relative '../ext'
+
 module Datadog
   module Tracing
     module Contrib

diff --git a/lib/datadog/tracing/contrib/aws/service/kinesis.rb b/lib/datadog/tracing/contrib/aws/service/kinesis.rb
@@ -1,5 +1,8 @@
 # frozen_string_literal: true
 
+require_relative './base'
+require_relative '../ext'
+
 module Datadog
   module Tracing
     module Contrib

diff --git a/lib/datadog/tracing/contrib/aws/service/s3.rb b/lib/datadog/tracing/contrib/aws/service/s3.rb
@@ -1,5 +1,8 @@
 # frozen_string_literal: true
 
+require_relative './base'
+require_relative '../ext'
+
 module Datadog
   module Tracing
     module Contrib

diff --git a/lib/datadog/tracing/contrib/aws/service/sns.rb b/lib/datadog/tracing/contrib/aws/service/sns.rb
@@ -1,5 +1,8 @@
 # frozen_string_literal: true
 
+require_relative './base'
+require_relative '../ext'
+
 module Datadog
   module Tracing
     module Contrib

diff --git a/lib/datadog/tracing/contrib/aws/service/sqs.rb b/lib/datadog/tracing/contrib/aws/service/sqs.rb
@@ -1,5 +1,8 @@
 # frozen_string_literal: true
 
+require_relative './base'
+require_relative '../ext'
+
 module Datadog
   module Tracing
     module Contrib

diff --git a/...cing/contrib/aws/service/stepfunctions.rb → ...dog/tracing/contrib/aws/service/states.rb b/...cing/contrib/aws/service/stepfunctions.rb → ...dog/tracing/contrib/aws/service/states.rb
@@ -1,5 +1,8 @@
 # frozen_string_literal: true
 
+require_relative './base'
+require_relative '../ext'
+
 module Datadog
   module Tracing
     module Contrib

diff --git a/lib/datadog/tracing/contrib/aws/services.rb b/lib/datadog/tracing/contrib/aws/services.rb
@@ -1,3 +1,11 @@
+require_relative './service/sqs'
+require_relative './service/sns'
+require_relative './service/dynamodb'
+require_relative './service/kinesis'
+require_relative './service/eventbridge'
+require_relative './service/states'
+require_relative './service/s3'
+
 module Datadog
   module Tracing
     module Contrib

diff --git a/...ing/contrib/aws/service/stepfunctions.rbs → ...og/tracing/contrib/aws/service/states.rbs b/...ing/contrib/aws/service/stepfunctions.rbs → ...og/tracing/contrib/aws/service/states.rbs
diff --git a/spec/datadog/tracing/contrib/aws/integration_spec.rb b/spec/datadog/tracing/contrib/aws/integration_spec.rb
@@ -1,5 +1,3 @@
-require 'datadog/tracing/contrib/support/spec_helper'
-
 require 'datadog/tracing/contrib/aws/integration'
 
 RSpec.describe Datadog::Tracing::Contrib::Aws::Integration do

diff --git a/spec/datadog/tracing/contrib/aws/parsed_context_spec.rb b/spec/datadog/tracing/contrib/aws/parsed_context_spec.rb
@@ -1,5 +1,3 @@
-require 'datadog/tracing/contrib/support/spec_helper'
-
 require 'aws-sdk'
 require 'datadog/tracing/contrib/aws/parsed_context'
 

diff --git a/spec/datadog/tracing/contrib/aws/service/dynamobdb_spec.rb b/spec/datadog/tracing/contrib/aws/service/dynamobdb_spec.rb
@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
-require 'rspec'
-require 'lib/datadog/tracing/contrib/aws/service/base'
-require 'lib/datadog/tracing/contrib/aws/service/dynamodb'
+require 'datadog/tracing/contrib/aws/service/dynamodb'
 
 RSpec.describe Datadog::Tracing::Contrib::Aws::Service::DynamoDB do
   let(:span) { instance_double('Span') }

diff --git a/spec/datadog/tracing/contrib/aws/service/eventbrige_spec.rb b/spec/datadog/tracing/contrib/aws/service/eventbrige_spec.rb
@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
-require 'rspec'
-require 'lib/datadog/tracing/contrib/aws/service/base'
-require 'lib/datadog/tracing/contrib/aws/service/eventbridge'
+require 'datadog/tracing/contrib/aws/service/eventbridge'
 
 RSpec.describe Datadog::Tracing::Contrib::Aws::Service::EventBridge do
   let(:span) { instance_double('Span') }

diff --git a/spec/datadog/tracing/contrib/aws/service/kinesis_spec.rb b/spec/datadog/tracing/contrib/aws/service/kinesis_spec.rb
@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
-require 'rspec'
-require 'lib/datadog/tracing/contrib/aws/service/base'
-require 'lib/datadog/tracing/contrib/aws/service/kinesis'
+require 'datadog/tracing/contrib/aws/service/kinesis'
 
 RSpec.describe Datadog::Tracing::Contrib::Aws::Service::Kinesis do
   let(:span) { instance_double('Span') }

diff --git a/spec/datadog/tracing/contrib/aws/service/s3_spec.rb b/spec/datadog/tracing/contrib/aws/service/s3_spec.rb
@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
-require 'rspec'
-require 'lib/datadog/tracing/contrib/aws/service/base'
-require 'lib/datadog/tracing/contrib/aws/service/s3'
+require 'datadog/tracing/contrib/aws/service/s3'
 
 RSpec.describe Datadog::Tracing::Contrib::Aws::Service::S3 do
   let(:span) { instance_double('Span') }

diff --git a/spec/datadog/tracing/contrib/aws/service/sns_spec.rb b/spec/datadog/tracing/contrib/aws/service/sns_spec.rb
@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
-require 'rspec'
-require 'lib/datadog/tracing/contrib/aws/service/base'
-require 'lib/datadog/tracing/contrib/aws/service/sns'
+require 'datadog/tracing/contrib/aws/service/sns'
 
 RSpec.describe Datadog::Tracing::Contrib::Aws::Service::SNS do
   let(:span) { instance_double('Span') }

diff --git a/spec/datadog/tracing/contrib/aws/service/sqs_spec.rb b/spec/datadog/tracing/contrib/aws/service/sqs_spec.rb
@@ -1,9 +1,6 @@
 # frozen_string_literal: true
 
-require 'lib/datadog/tracing/contrib/aws/service/base'
-require 'lib/datadog/tracing/contrib/aws/service/sqs'
-require 'spec_helper'
-require 'rspec'
+require 'datadog/tracing/contrib/aws/service/sqs'
 
 RSpec.describe Datadog::Tracing::Contrib::Aws::Service::SQS do
   let(:span) { instance_double('Span') }

diff --git a/...contrib/aws/service/stepfunctions_spec.rb → ...racing/contrib/aws/service/states_spec.rb b/...contrib/aws/service/stepfunctions_spec.rb → ...racing/contrib/aws/service/states_spec.rb
@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
-require 'rspec'
-require 'lib/datadog/tracing/contrib/aws/service/base'
-require 'lib/datadog/tracing/contrib/aws/service/stepfunctions'
+require 'datadog/tracing/contrib/aws/service/states'
 
 RSpec.describe Datadog::Tracing::Contrib::Aws::Service::States do
   let(:span) { instance_double('Span') }

diff --git a/spec/datadog/tracing/contrib/aws/services_spec.rb b/spec/datadog/tracing/contrib/aws/services_spec.rb
@@ -0,0 +1,49 @@
+require 'datadog/tracing/contrib/aws/services'
+
+RSpec.describe Datadog::Tracing::Contrib::Aws do
+  describe 'constant `SERVICES`' do
+    subject(:services) { Datadog::Tracing::Contrib::Aws::SERVICES }
+
+    it do
+      expect(services).to be_frozen
+    end
+
+    it do
+      expect(services.length).to eq(109)
+    end
+
+    it 'contains strings' do
+      expect(services).to all(be_a String)
+    end
+
+    it 'contains frozen strings', skip: 'DEV-2.0: frozen string' do
+      expect(services).to all(be_frozen)
+    end
+  end
+
+  describe 'constant `SERVICE_HANDLERS`' do
+    subject(:handlers) { Datadog::Tracing::Contrib::Aws::SERVICE_HANDLERS }
+
+    it do
+      expect(handlers.length).to eq(7)
+    end
+
+    it do
+      expect(handlers.keys).to contain_exactly(
+        'sqs',
+        'sns',
+        'dynamodb',
+        'kinesis',
+        'eventbridge',
+        'states',
+        's3'
+      )
+    end
+
+    it do
+      expect(handlers.values).to all(
+        be_a Datadog::Tracing::Contrib::Aws::Service::Base
+      )
+    end
+  end
+end