Skip to content

Commit

Permalink
[PROF-10589] Add benchmarking configuration for gvl profiling
Browse files Browse the repository at this point in the history
**What does this PR do?**

This PR tweaks our nightly benchmark runs configuration to add a new
configuration that enables GVL profiling.

**Motivation:**

This will allow us to have better coverage for testing this feature.

**Additional Notes:**

This was previously blocked on upgrading the gitlab image that
we run in the benchmarking platform, which I finally took care
of in DataDog/benchmarking-platform#108 .

**How to test the change?**

I'll trigger a manual run to validate it's running fine and report
back ;)
  • Loading branch information
ivoanjo committed Oct 25, 2024
1 parent 91d883f commit ce60191
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions .gitlab/benchmarks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,14 @@ only-profiling-heap-clean-after-gc:
DD_PROFILING_HEAP_CLEAN_AFTER_GC_ENABLED: "true"
ADD_TO_GEMFILE: "gem 'datadog', github: 'datadog/dd-trace-rb', ref: '$CI_COMMIT_SHA'"

only-profiling-gvl:
extends: .benchmarks
variables:
DD_BENCHMARKS_CONFIGURATION: only-profiling
DD_PROFILING_ENABLED: "true"
DD_PROFILING_PREVIEW_GVL_ENABLED: "true"
ADD_TO_GEMFILE: "gem 'datadog', github: 'datadog/dd-trace-rb', ref: '$CI_COMMIT_SHA'"

profiling-and-tracing:
extends: .benchmarks
variables:
Expand Down

0 comments on commit ce60191

Please sign in to comment.