chore(ci): pin mariadb container to 10.7 image tag (backport #3913) #4395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
MariaDB latest only works on newer versions of Docker (see MariaDB/mariadb-docker#434). So we are pinning to mariadb:10.7 for now to ensure consistent startup of the container in CircleCI. (cherry picked from commit 27a55df)
14 tasks
mabdinur
previously approved these changes
Oct 27, 2022
mabdinur
added
the
changelog/no-changelog
Yun-Kim
previously approved these changes
Oct 27, 2022
|
Requires: #4401. Should we combine both backports into one PR, neither will pass on its own. |
… (#4401) * chore(mariadb): update tests to support mariadb>=1.1.0 (#3883) The latest version of mariadb client library requires a newer version of the C library in order to build. This PR updates snapshot tests to account for newly supported db.rowcount for mariadb query spans. This PR depends on #3884 to be merged and update our dev image first before this can pass. This is a testing only fix, our integration continues to work fine for mariadb>=1.1.0, but our test suite was not setup for it. Co-authored-by: Kyle Verhoog <[email protected]> Co-authored-by: Munir Abdinur <[email protected]> (cherry picked from commit 22746a3) # Conflicts: # tests/contrib/mariadb/test_mariadb.py * fix conflicts and add missing snapshots Co-authored-by: Brett Langdon <[email protected]> Co-authored-by: Munir Abdinur <[email protected]> Co-authored-by: Munir Abdinur <[email protected]>
Kyle-Verhoog
approved these changes
Oct 27, 2022
mabdinur
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #3913 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com