fix(sanic): support version 21.x (#2240) #2379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yun-Kim
reviewed
May 3, 2021
Kyle-Verhoog
reviewed
May 4, 2021
jd
previously requested changes
May 6, 2021
Kyle-Verhoog
previously approved these changes
May 6, 2021
|
Tests are broken because |
|
A fix for pytest-sanic was pushed to yunstanford/pytest-sanic#52. |
nizox
changed the title
brettlangdon
previously approved these changes
May 20, 2021
Yun-Kim
previously approved these changes
May 20, 2021
Kyle-Verhoog
previously approved these changes
May 20, 2021
nizox
dismissed stale reviews from Kyle-Verhoog, Yun-Kim, and brettlangdon
via
0b0d273
Kyle-Verhoog
previously approved these changes
May 24, 2021
brettlangdon
approved these changes
May 25, 2021
brettlangdon
approved these changes
Jun 17, 2021
Kyle-Verhoog
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The latest major sanic release (21.x) introduced support for streaming responses and our instrumentation broke due to a change of method's signature (reported by #2240). This PR updates our instrumentation to support both the latest version and older versions.
Sanic 20.12 and older versions have
Sanic.handle_request(request, write_callback, stream_callback)while Sanic 21 and newer versions haveSanic.handle_request(request). In both cases, a request starts when this method is called and terminates when the method returns. This PR changes the request span finish when thehandle_requestmethod returns instead of when eitherwrite_callbackorstream_callbackis called.A
Pinis also attached to therequest.ctxobject to pass the tracer to newly instrumented methods:Request.respondreplacingwrite_callback&stream_callbackin Sanic 21.Sanic._run_request_middlewarebecauserequest.match_infois not filled anymore beforeSanic.handle_requestis called in Sanic 21.Checklist