Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rasp telemetry #3061

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Add rasp telemetry #3061

wants to merge 12 commits into from

Conversation

estringana
Copy link
Contributor

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 37.50000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 72.94%. Comparing base (c11372f) to head (09e5c68).

Files with missing lines Patch % Lines
.../Integrations/Filesystem/FilesystemIntegration.php 0.00% 4 Missing ⚠️
appsec/src/extension/commands_helpers.c 0.00% 3 Missing ⚠️
appsec/src/extension/ddappsec.c 50.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3061      +/-   ##
============================================
- Coverage     72.97%   72.94%   -0.03%     
  Complexity     2790     2790              
============================================
  Files           139      139              
  Lines         15273    15280       +7     
  Branches       1043     1047       +4     
============================================
+ Hits          11145    11146       +1     
- Misses         3577     3581       +4     
- Partials        551      553       +2     
Flag Coverage Δ
appsec-extension 68.28% <50.00%> (-0.09%) ⬇️
tracer-php 74.73% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
appsec/src/extension/commands/request_exec.c 100.00% <100.00%> (ø)
appsec/src/extension/commands_helpers.c 62.56% <0.00%> (-0.47%) ⬇️
appsec/src/extension/ddappsec.c 77.87% <50.00%> (-0.77%) ⬇️
.../Integrations/Filesystem/FilesystemIntegration.php 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c11372f...09e5c68. Read the comment docs.

@estringana estringana force-pushed the estringana/add-rasp-telemetry branch from 5dd1562 to 0627472 Compare January 29, 2025 11:59
@estringana estringana marked this pull request as ready for review February 3, 2025 12:13
@estringana estringana requested review from a team as code owners February 3, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants