Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASM] Strip new line from version on CMake #3027

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

Anilm3
Copy link
Contributor

@Anilm3 Anilm3 commented Jan 9, 2025

Description

Fix to prevent the need for #3024

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@Anilm3 Anilm3 requested a review from a team as a code owner January 9, 2025 13:17
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.93%. Comparing base (efd9338) to head (d3e1f67).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3027   +/-   ##
=========================================
  Coverage     72.93%   72.93%           
  Complexity     2781     2781           
=========================================
  Files           139      139           
  Lines         15166    15166           
  Branches       1022     1022           
=========================================
  Hits          11062    11062           
  Misses         3552     3552           
  Partials        552      552           
Flag Coverage Δ
appsec-extension 67.99% <ø> (ø)
tracer-php 74.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efd9338...d3e1f67. Read the comment docs.

Copy link
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :-)

@Anilm3 Anilm3 merged commit 9607a5f into master Jan 9, 2025
676 of 752 checks passed
@Anilm3 Anilm3 deleted the anilm3/allow-nl-version-cmake branch January 9, 2025 14:05
@github-actions github-actions bot added this to the 1.7.0 milestone Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants