Fix SpanLink::fromHeaders() crash with no or invalid propagated tags #3025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3025 +/- ##
============================================
- Coverage 74.80% 72.93% -1.87%
Complexity 2781 2781
============================================
Files 112 139 +27
Lines 11017 15166 +4149
Branches 0 1022 +1022
============================================
+ Hits 8241 11062 +2821
- Misses 2776 3552 +776
- Partials 0 552 +552
Flags with carried forward coverage won't be shown. Click here to find out more. see 27 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Signed-off-by: Bob Weinand <[email protected]>
bwoebi
force-pushed
the
bob/from-headers-null
branch
from
a4b7337 to
58ba6da
Compare
realFlowControl
approved these changes
Jan 9, 2025
realFlowControl
pushed a commit
that referenced
this pull request
Jan 9, 2025
…3025) Signed-off-by: Bob Weinand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple NULL check missing.