Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix appsec pipeline #2982

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Conversation

estringana
Copy link
Contributor

@estringana estringana commented Dec 3, 2024

Description

Appsec pipeline was broken. This PR fixes all errors:

  • Update appsec ubuntu docker images to 24:04
  • Amend helper tests generating segmentation fault on fuzzer
  • Fix linting issues

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@estringana estringana requested a review from a team as a code owner December 3, 2024 11:12
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.12%. Comparing base (a2b1c2d) to head (42062a8).

Files with missing lines Patch % Lines
appsec/src/extension/configuration.c 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2982      +/-   ##
============================================
- Coverage     74.82%   73.12%   -1.71%     
  Complexity     2741     2741              
============================================
  Files           110      137      +27     
  Lines         10863    14907    +4044     
  Branches          0      992     +992     
============================================
+ Hits           8128    10900    +2772     
- Misses         2735     3462     +727     
- Partials          0      545     +545     
Flag Coverage Δ
appsec-extension 68.54% <0.00%> (?)
tracer-php 74.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
appsec/src/extension/configuration.c 61.38% <0.00%> (ø)

... and 26 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2b1c2d...42062a8. Read the comment docs.

@realFlowControl
Copy link
Member

I might not have anything todo with this PR, just pointing towards it: https://app.circleci.com/pipelines/github/DataDog/dd-trace-php/18492/workflows/75369509-19ae-4e01-8f0d-e09c76fcd742/jobs/5700927

@estringana
Copy link
Contributor Author

I might not have anything todo with this PR, just pointing towards it: https://app.circleci.com/pipelines/github/DataDog/dd-trace-php/18492/workflows/75369509-19ae-4e01-8f0d-e09c76fcd742/jobs/5700927

Nah, it was just a coincidence we both decided to do this at the same time 😆

@estringana estringana changed the title Update appsec ubuntu docker images to 24:04 Fix appsec pipeline Dec 4, 2024
@estringana estringana requested a review from a team as a code owner December 4, 2024 10:14
@estringana estringana force-pushed the estringana/update-appsec-ubuntu-images branch from 9087517 to 42062a8 Compare December 4, 2024 10:47
@pr-commenter
Copy link

pr-commenter bot commented Dec 4, 2024

Benchmarks [ appsec ]

Benchmark execution time: 2024-12-04 11:23:46

Comparing candidate commit 42062a8 in PR branch estringana/update-appsec-ubuntu-images with baseline commit a2b1c2d in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

@Anilm3
Copy link
Contributor

Anilm3 commented Dec 4, 2024

LGTM, thanks for fixing this!

@estringana estringana merged commit 34baa56 into master Dec 4, 2024
698 of 724 checks passed
@estringana estringana deleted the estringana/update-appsec-ubuntu-images branch December 4, 2024 11:53
@github-actions github-actions bot added this to the 1.6.0 milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants