-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix appsec pipeline #2982
Fix appsec pipeline #2982
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2982 +/- ##
============================================
- Coverage 74.82% 73.12% -1.71%
Complexity 2741 2741
============================================
Files 110 137 +27
Lines 10863 14907 +4044
Branches 0 992 +992
============================================
+ Hits 8128 10900 +2772
- Misses 2735 3462 +727
- Partials 0 545 +545
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 26 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
I might not have anything todo with this PR, just pointing towards it: https://app.circleci.com/pipelines/github/DataDog/dd-trace-php/18492/workflows/75369509-19ae-4e01-8f0d-e09c76fcd742/jobs/5700927 |
Nah, it was just a coincidence we both decided to do this at the same time 😆 |
9087517
to
42062a8
Compare
Benchmarks [ appsec ]Benchmark execution time: 2024-12-04 11:23:46 Comparing candidate commit 42062a8 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. |
LGTM, thanks for fixing this! |
Description
Appsec pipeline was broken. This PR fixes all errors:
Reviewer checklist