Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(profiling) visualise opcache restarts in the timeline #2946

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

realFlowControl
Copy link
Member

@realFlowControl realFlowControl commented Nov 13, 2024

Description

PROF-10120

image

Belongs to:

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@github-actions github-actions bot added the profiling Relates to the Continuous Profiler label Nov 13, 2024
@realFlowControl realFlowControl force-pushed the florian/opcache-restarts branch from 35291b3 to 4cdb855 Compare November 13, 2024 12:40
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.62%. Comparing base (ba07209) to head (282c842).
Report is 41 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2946   +/-   ##
=========================================
  Coverage     73.62%   73.62%           
  Complexity     2529     2529           
=========================================
  Files           109      109           
  Lines         10410    10410           
=========================================
  Hits           7664     7664           
  Misses         2746     2746           
Flag Coverage Δ
tracer-php 73.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba07209...282c842. Read the comment docs.

@pr-commenter
Copy link

pr-commenter bot commented Nov 13, 2024

Benchmarks [ profiler ]

Benchmark execution time: 2024-11-14 09:23:01

Comparing candidate commit 282c842 in PR branch florian/opcache-restarts with baseline commit ba07209 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 9 unstable metrics.

@realFlowControl realFlowControl force-pushed the florian/opcache-restarts branch from 4cdb855 to 1db8a8d Compare November 13, 2024 13:03
@realFlowControl realFlowControl force-pushed the florian/opcache-restarts branch from 1db8a8d to 0975799 Compare November 13, 2024 13:47
@realFlowControl realFlowControl marked this pull request as ready for review November 14, 2024 09:08
@realFlowControl realFlowControl requested a review from a team as a code owner November 14, 2024 09:08
@realFlowControl realFlowControl merged commit 02fe693 into master Nov 14, 2024
488 of 511 checks passed
@realFlowControl realFlowControl deleted the florian/opcache-restarts branch November 14, 2024 16:19
@github-actions github-actions bot added this to the 1.5.0 milestone Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
profiling Relates to the Continuous Profiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants