-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support multiple PHP_INI_SCAN_DIR
's
#2941
support multiple PHP_INI_SCAN_DIR
's
#2941
Conversation
599d8d6
to
4ab0132
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2941 +/- ##
============================================
- Coverage 82.10% 73.97% -8.13%
Complexity 2527 2527
============================================
Files 108 108
Lines 10360 10360
============================================
- Hits 8506 7664 -842
- Misses 1854 2696 +842
Flags with carried forward coverage won't be shown. Click here to find out more. see 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
4ab0132
to
f922472
Compare
f922472
to
6479b61
Compare
Co-authored-by: Bob Weinand <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks.
Description
In case a user sets the
PHP_INI_SCAN_DIR
environment variable to a special value with a leading or trailing:
or has multiple directories separated by the default path separator, we need to handle this accordingly.In case they use the trailing or leading
:
to just add or prepend to the default directory, there is no way for us to find that original value anymore, so we "just" always use the first explicitly defined path.This is documented upstream at https://www.php.net/manual/en/configuration.file.php#configuration.file.scan
Thanks @rp-thomas for reporting
Reviewer checklist