Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix heap corruption after apache reloads (appsec) #2928

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

cataphract
Copy link
Contributor

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@cataphract cataphract requested a review from a team as a code owner November 5, 2024 18:51
@cataphract cataphract merged commit e314256 into master Nov 5, 2024
250 of 510 checks passed
@cataphract cataphract deleted the glopes/appsec-sighup-corruption branch November 5, 2024 18:56
@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.38%. Comparing base (1b40137) to head (adf82ce).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
appsec/src/extension/ddtrace.c 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2928      +/-   ##
============================================
- Coverage     72.39%   72.38%   -0.01%     
  Complexity     2526     2526              
============================================
  Files           135      135              
  Lines         14400    14400              
  Branches        989      989              
============================================
- Hits          10425    10424       -1     
  Misses         3433     3433              
- Partials        542      543       +1     
Flag Coverage Δ
appsec-extension 68.34% <0.00%> (-0.03%) ⬇️
tracer-php 73.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
appsec/src/extension/ddtrace.c 59.55% <0.00%> (-0.45%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b40137...adf82ce. Read the comment docs.

@github-actions github-actions bot added this to the 1.5.0 milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants