Update spdlog so it works with recent musls

[cataphract]

gabime/spdlog@287a00d

Description

Reviewer checklist

• Test coverage seems ok.
• Appropriate labels assigned.

[bwoebi]

That probably fixed that particular issue, but now a load of new errors appear, probably due to the other changes between these commits...

And please rebase the commit on top of a newer master, CI fails too much too :-)

[cataphract]

Rebase and fixed the errors related to the new spdlog, at least in the main helper binary.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.39%. Comparing base (352d3ba) to head (f34823a).

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #2921   +/-   ##
=========================================
  Coverage     72.39%   72.39%           
  Complexity     2526     2526           
=========================================
  Files           135      135           
  Lines         14400    14400           
  Branches        989      989           
=========================================
  Hits          10425    10425           
  Misses         3433     3433           
  Partials        542      542           

Flag	Coverage Δ
appsec-extension	68.36% <ø> (ø)
tracer-php	73.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 352d3ba...f34823a. Read the comment docs.

[pr-commenter]

Benchmarks [ appsec ]

Benchmark execution time: 2024-11-04 19:18:36

Comparing candidate commit f34823a in PR branch glopes/update-spdlog with baseline commit 352d3ba in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

[bwoebi]

Looks good, thanks Gustavo.

[Anilm3]

lgtm

[Anilm3]

The integration tests are failing because they're expecting an image for PHP 8.4 which doesn't exist at the moment, you can disable the 8.4 test for now and I'll add this to the backlog.